[Resolved] Upgrade to the latest version of Toolset plugins, get some errors

[Author]

Posts

[Luo Yang]

Please try these:
1) Login as user "Beda" to your website hidden link
2) Test your website home page
It works fine: hidden link

See my screenshot cache-problem.JPG, it works fine

So it should be a cache problem of your website.

Seriously, please provide copy of your problem website, so we can work on other PHP error issue.

[smileBeda]

You make me cry 🙂

[smileBeda]

Just for your info the error is known to you guys since at least August

https://toolset.com/forums/topic/fatal-error-when-trying-to-update-access-etc/

So, still want a duplicate? Or is Shane's ticket enough proof that Toolset has some massive issues right now?
I mean, what an amazing solution there!!!!

[Luo Yang]

I have searched it in YT and P2, there isn't similar report.

You know our workflow, in order to escalate the issues, I need to duplicate the same problem in my localhost.
You can provide detail steps to duplicate the same problem in a fresh WP installation or provide a copy of website, so we can proceed to debug and escalate this issue.

Private message box enabled again.

[smileBeda]

I can't believe it.
There is a ticket from august with the precise same error.
Of course you can't find it in p2 or yt, Shane did not report it, as far I can see in that other ticket.

Just try to update toolset: Fails in error and can't be done
Then update manually and activate CRED: WPOD and error as mentioned

On the duplicate just try to activate CRED, and see the error.
hidden link, hidden link
Same error as reported a month ago at https://toolset.com/forums/topic/fatal-error-when-trying-to-update-access-etc/

The time I spend for this, is costing a lot of money. Consider that this is the same for every other developer and user out there using toolset.

I am sure there are other ways of making sure errors are fixed, like, for example, start investigating them when the errors are reported.

[smileBeda]

1. https://toolset.com/forums/topic/upgrade-to-the-latest-version-of-toolset-plugins-get-some-errors/#post-1790153
This issue also reported by https://toolset.com/forums/topic/fatal-error-when-trying-to-update-access-etc/

This is as follows:
Since CRED 2.6 the file cred-frontend-editor/application/controllers/compatibility/wpml/integration/forms_translation/legacy.php has code that extends an abstract class.
The class that extends the abstract class registers a method register_strings with arguments as follows:

$form, $form_data

In the abstract class "base", the same method register_strings is registered with args as follows:

\WP_Post $form, $form_data

Now, if you activate CRED on a legacy site with forms that code is triggered.
It fails with a WPOD and no error will be logged, but the underlying error will be

An error of type E_COMPILE_ERROR was caused in line 10 of the file /cred-frontend-editor/application/controllers/compatibility/wpml/integration/forms_translation/legacy.php.

Now if you where to debug that, using

error_reporting(E_ALL | E_STRICT |  E_ERROR | E_WARNING | E_PARSE | E_COMPILE_ERROR);

then you would see that

Fatal error: Declaration of OTGS\Toolset\CRED\Controller\Compatibility\Wpml\Integration\FormsTranslation\Legacy::register_strings($form, $form_data) must be compatible with OTGS\Toolset\CRED\Controller\Compatibility\Wpml\Integration\FormsTranslation\Base::register_strings(WP_Post $form, $form_data) in /cred-frontend-editor/application/controllers/compatibility/wpml/integration/forms_translation/legacy.php on line 10

This leads us to the real error:
Extending class Legacy should declare register_strings as well with \WP_Post $form, $form_data

If you do that, the issue is resolved.

I think this should once again be enough of a debug to forward. This issue will/does happen on every legal site with forms and the debug should clarify what needs fixing.

Thanks

[Luo Yang]

I am downloading the files, will update here if find anything

[Luo Yang]

I can install your duplicator package in my localhost, it is using all latest version of Toolset plugins, I have tried these:
1) Deactivate "Wordfence Security" plugin, since it keeps on displaying error when I try to login.
2) Login the test site
3) Activate Toolset Forms plugin + "Wordfence Security" plugin, it works fine in my localhost, see my screenshot plugins.JPG front-end.JPG
There isn't any PHP error message, so it should be a server/compatibility issue of your website.

In my localhost, I am using Apache 2.4.41 + PHP 7.4.10 + MariaDB 10.4.10, and I have tried PHP 7.3.12 and PHP 7.4.0, it works fine too.

What PHP version are you using in your website? please provide your website debug information by following our document:
https://toolset.com/faq/provide-debug-information-faster-support/

[smileBeda]

Indeed happens only with or below PHP version 7.1.32

In any case the debug above is clear and shows why the issue happens.
Maybe more modern PHP can deal with abstract methods being initialised with different args, lower versions can't.

Can you confirm?

[Luo Yang]

Yes, I can confirm your duplicator package works fine with PHP version 7.4+, and according to WP document:
https://wordpress.org/about/requirements/

To run WordPress we recommend your host supports:
PHP version 7.4 or greater.

[smileBeda]

Thanks, I know how to avoid an incompatibility with PHP and I know about WP's recommendations.

However, I cannot update this host to latest PHP because SiteGround is not compatible with it (their ZipArchive Extension features are not working on newer PHP version, see https://wordpress.org/support/topic/ziparchive-extension-missing-from-php-7-4-3/).

Also, WordPress and Toolset, while recommending PHP 7.4 or greater, it does not require it.

Indeed Toolset itself guarantees on its requirements page https://toolset.com/toolset-requirements/ that it will work with any version from PHP 5.6 and above.

I would like to ask you to take this confirmed, already debugged by me, real bug and report it to the Developers for a fix, if possible.
Clearly it can't be that the solution Toolset offers is like here https://toolset.com/forums/topic/fatal-error-when-trying-to-update-access-etc/ (Do nothing, don't worry, don't update), or like in this ticket (please update PHP)

Instead, the solution is to fix the Bug that happens with lower than xy PHP version.

Many thanks for considering this.

[Luo Yang]

I was asking for your web server debug information:
https://toolset.com/forums/topic/upgrade-to-the-latest-version-of-toolset-plugins-get-some-errors/page/2/#post-1792627
If you can provide it from the start, that will help us to debug the issue.

And thanks for the details, I can duplicate the problem with PHP 5.6, and have escalated this thread.

[Luo Yang]

It is fixed in the latest version of Toolset Forms plugin 2.6.1, you can download it here:
https://toolset.com/account/downloads/

Please feedback if the problem is fixed, thanks

[smileBeda]

I'm sorry the delay Luo.

Yes, I confirm the last update has fixed this PHP compatibility issue.
I updated through the native WP Plugins list, so I didn't test the Installer Update mechanism, but assume it is resolved, since I had no issues updating.

Related to the intermitted 503 and 504 errors, I have a ticket with Waqar that probably located the cause of that issue, so that's OK too.

For me we can close this here.

PS, the forum doe snot let me reply without reopening the ticket.
Sorry for that!

[smileBeda]

My issue is resolved now. Thank you!