[Resolved] PHP error occurring on redirect after login form

[Author]

Posts

[simonM-5]

Hi Support

We are recently receiving the following PHP errors pertaining to the Toolset-provided code snippet "conditional-redirect-on-successful-login" in a previous ticket. This worked fine before. The error is preventing any new users from being logging in successfully on the site.

ERROR MESSAGE:

Fatal error: Uncaught Error: Call to undefined function str_contains() in /.../dev/wp-content/toolset-customizations/conditional-redirect-on-successful-login.php:64 Stack trace: #0 /.../dev/wp-includes/class-wp-hook.php(303): my_login_redirect('hidden link...', 'hidden link...', Object(WP_User)) #1 /.../dev/wp-includes/plugin.php(189): WP_Hook->apply_filters('hidden link...', Array) #2 /.../dev/wp-login.php(1178): apply_filters('login_redirect', 'hidden link...', 'hidden link...', Object(WP_User)) #3 {main} thrown in /.../dev/wp-content/toolset-customizations/conditional-redirect-on-successful-login.php on line 64

Our original ticket for the redirect code snippet was this one:
https://toolset.com/forums/topic/conditional-login-in-different-languages-with-wpml-enabled/

and a subsequent tickets addressed an issue while logging in in German:
https://toolset.com/forums/topic/conditional-redirects-not-working-for-all-roles-in-german/

whereafter it worked too. So I don't understand why it has stopped working all of a sudden as we didn't change that code since.

The issue does not occur for successfully registered users of role "native_nanny" or "family", so I suspect that the redirect issue is only for brand new users (roles "unverified_family" and "unverified_nanny"), who would be redirected to a different place, as given by the Toolset Code Snippet "conditional-redirect-on-successful-login".

STEPS TO REPRODUCE:

1) Click either "Sign Up" to register as a new Unverified Family or "Become a Native Nanny" to register as a new Unverified Nanny
2) Fill out the email, first name, last name, password and do reCaptcha if necessary.
3) You are redirected to the login form. Once you enter the email address and password just specified the error occurs.

I found during testing that if you follow the following steps, you will see that the login was successful, but the redirect is failing.

4) Immediately after you get the error, click Back on the browser
5) You are taken back to the login screen and it looks like you're not logged in, however if you simply click the WPML language flag top right, you will see that the login works and you ARE redireted to the login page in German, but you are acutally logged in, as can be seen in the menu top right. It has changed to the menu for logged in users.

Thanks and best regards
Simon

[Luo Yang]

Hello,

Please check PHP document:
hidden link
The PHP function str_contains() was introduced in PHP 8.0, but your webserver is using PHP 7.4.3
hidden link
So it is expected result to get the PHP errors you mentioned above.

I have done below modifications in your website:
Edit the custom codes "onditional-redirect-on-successful-login.php", lines 8~13, add below codes:

if (!function_exists('str_contains')) {
    function str_contains(string $haystack, string $needle): bool
    {
        return '' === $needle || false !== strpos($haystack, $needle);
    }
}

Please test again, check if it is fixed.

[simonM-5]

Hi Luo

Thanks, that's working again, however according to Toolset website: https://toolset.com/toolset-requirements/, PHP 8 isn't supported (yet).

"Important notes:
PHP 8 is currently not supported due to some issues. We’re working on fixing this. In the meantime, please use PHP 7 version"

Is this still accurate? Is it recommended to upgrade to PHP 8?

Kind regards
Simon

[Luo Yang]

Yes, you are right, it is not to use PHP 8.0 with Toolset plugins yet.

And there is a misunderstanding, the custom codes I provided above is a custom PHP function, it should be able to works in both PHP 7.4 and 8.0, see the first line:
if (!function_exists('str_contains')) {

That means if you are using PHP 8.0, then these codes won't take effect, if it is PHP 7.4, then it takes effect.

[simonM-5]

My issue is resolved now. Thank you!