[Resolved] php warning message when formatting currency field

[Author]

Posts

[PaulS4783]

I am trying to format a custom field "price" for zero decimals and to use commas.

I created a custom shortcode:

// format numbers nicely with zero decimals and with commas
function format_my_number($atts) {
    $num = $atts["num"];
     
    return number_format($num, 0, '.', ',');
}
add_shortcode("format-currency", "format_my_number");

And used it like this in the content template:

 <h2>[format-currency num='[types field='price' output="raw" format='FIELD_VALUE'][/types]'] JPY</h2>

It seems to "work" but when I look at the template on the backend I can see a warning message:

Warning: number_format() expects parameter 1 to be float, string given in /home/mysite/public_html/wp-content/themes/astra-child/functions.php on line 31

The "price" custom field is a "number" so I am not sure why it says "string given" or shows this message.
Thoughts?

[Nigel]

All post meta is stored as a string in wp_postmeta. (Even arrays are serialised and stored as strings.)

Use floatval to convert the string to a floating number (which number_format expects).

See hidden link

[PaulS4783]

Thank you.
Function now works. As follows:

// format numbers nicely with zero decimals and with commas 
// function converts meta data which is stored as a string to a float
function format_my_number($atts) {
    $num = $atts["num"];
    $float_value_of_var = floatval($num);
     
    return number_format($float_value_of_var, 0, '.', ',');
}
add_shortcode("format-currency", "format_my_number");