This is the technical support forum for Toolset - a suite of plugins for developing WordPress sites without writing PHP.
Everyone can read this forum, but only Toolset clients can post in it. Toolset support works 6 days per week, 19 hours per day.
| Sun | Mon | Tue | Wed | Thu | Fri | Sat |
|---|---|---|---|---|---|---|
| - | 9:00 – 13:00 | 9:00 – 13:00 | 9:00 – 13:00 | 9:00 – 13:00 | 9:00 – 13:00 | - |
| - | 14:00 – 18:00 | 14:00 – 18:00 | 14:00 – 18:00 | 14:00 – 18:00 | 14:00 – 18:00 | - |
Supporter timezone: Asia/Hong_Kong (GMT+08:00)
This topic contains 14 replies, has 3 voices.
Last updated by Geoffrey Cleverley 7 years, 9 months ago.
Assisted by: Luo Yang.
Hey Luo, thanks for your continuing support,
So I adjusted the code as above, but it still wasn't writing to the parent field. However it got me looking at the maths again.
What I did was simplify the averages and added 'lower than or equal to' operators. I also valued the averages at 0 prior to the calclulation, matching the averaging shortcode function from where I got this maths.
My 'cred_save_data' action now looks like this:
<?php
add_action('cred_save_data', 'save_average_review_rating_to_parent_book',10,2);
function save_average_review_rating_to_parent_book($post_id, $form_data) {
if ($form_data['id']==250) {
$parent_slug = 'book'; // parent post type slug
$child_slug = 'review'; // child post type slug
$rating_field_slug = 'rating'; // the rating field slug in child post
$average_field_slug = 'average-review'; // the average rating field slug in parent post
$parent_id = get_post_meta($post_id, '_wpcf_belongs_' . $parent_slug . '_id', true);
$child_posts = types_child_posts($child_slug, array('post_id' => $parent_id));
$sum = 0;
$num = 0;
foreach ($child_posts as $child_post) {
if(isset($child_post->fields[$rating_field_slug]))
{
$sum += $child_post->fields[$rating_field_slug];
$num ++;
}
}
$average = 0; //Added this, taken from the averages shortcode below
if($num>0)
{
$average = $sum/$num;
}
$res = $average;
if($average==0) $res = 0;
if($average>0.001 && $average<=0.5)$res = 0; //Added <=
if($average>0.501 && $average<=1.5) $res = 1;
if($average>1.501 && $average<=2.5) $res = 2;
if($average>2.501 && $average<=3.5) $res = 3;
if($average>3.501 && $average<=4.5) $res = 4;
if($average>4.501 && $average<=5) $res = 5;
//... here put more condition ...
update_post_meta($parent_id, 'wpcf-' . $average_field_slug, $res);
return $res;
}
};
?>
The good news is that it is now writing to the database, which is fantastic! (And this time I backed up immediately lol)
However, because my averages shortcode is using half stars I decided to replace the arithmetic in the shortcode function so that it matches the above.
I wanted to keep displaying the shortcode average, because I know it works and I could use it to check against the average being written to the parent upon submission of a review.
So now my average review shortcode function is as follows:
<?php
add_shortcode('rating-average', 'rating_average_func');
function rating_average_func() {
global $post;
$args = array(
'post_type' => 'review',
'meta_key' => '_wpcf_belongs_' . $post->post_type . '_id',
'meta_value' => $post->ID,
);
$child_posts = get_posts($args);
$sum = 0;
$num = 0;
foreach ($child_posts as $child_post) {
$rating = get_post_meta($child_post->ID, 'wpcf-rating', true);
if($rating)
{
$sum += $rating;
$num ++;
}
}
$average = 0;
if($num>0)
{
$average = $sum/$num;
}
$res = $average;
if($average==0) $res = 0;
if($average>0.001 && $average<=0.5)$res = 0;
if($average>0.501 && $average<=1.5) $res = 1;
if($average>1.501 && $average<=2.5) $res = 2;
if($average>2.501 && $average<=3.5) $res = 3;
if($average>3.501 && $average<=4.5) $res = 4;
if($average>4.501 && $average<=5) $res = 5;
//... here put more condition ...
return $res;
};
?>
As you can see, the arithmetic now matches, just differing in how to call the child post.
However there is a problem somewhere in my first 'cred_save_data' arithmetic. I can see this in the discrepancy between the output of the shortcode and the value being written to the parent custom field upon submission of my review form.
Please see the screenshots.
In the screenshots, you can see that the shortcode is returning correct averages on the front end.
However in the back end, the custom field is showing incorrect averages.
As best I can tell, the back end is summing the averages without including the average from the review form that activates the 'cred_save_data' action.
The funny thing is, that as more reviews are submitted this problem will become unnoticeable, as the averaging function itself, combined with the high rounding tolerances (no half stars) will smooth out this problem. I only noticed it because I have deleted most of the reviews to test the function. Once there are even 5 or 6 ratings the averaging function returns the correct star rating. (as you can see from the TekWar & Crimson screenshots)
Having said that, my OCD is screaming and initial beta users will be important.
Can you see where I am going wrong? Should I be using a 'Cred_before_save_data' action? Or is it purely an php arithmetic mistake?
Ever grateful for any insight and direction.
Jeff
