[Resolved] wpv_filter_quert applys to all Views

[Author]

Posts

[Pat]

Hello,

I'm coming back on a previews ticket (https://toolset.com/forums/topic/views-sorted-by-2-custom-fields/page/2/)
I have been able to make it work, but now, I discovered that the other Views are not working.

I have created a new Views for the "slider" postype and this Views is displaying "post" postypes!
Here is the function I placed in the function.php to get the sort on the first Views (ID 98) :

add_filter('wpv_filter_query', 'add_custom_fiels_to_view_query', 99, 3);
function add_custom_fiels_to_view_query($query_args, $view_settings, $view_id ) {
if ( $view_id != 98 ){
return;
}

$meta_query = array();
$meta_query[] = array('key' => 'wpcf-jour-cours');
$meta_query[] = array('key' => 'wpcf-heure-debut-cours');
$meta_query[] = array('key' => 'wpcf-minute-debut-cours');
if ( !isset($query_args['meta_query']) ){
$query_args['meta_query'] = array();
}
$query_args['meta_query'] = array_merge($meta_query, $query_args['meta_query']);
add_filter('posts_orderby', 'custom_order');

return $query_args;
}
function custom_order($orderby) {
global $wpdb;
return $wpdb->postmeta.'.meta_value ASC, mt1.meta_value ASC, mt2.meta_value ASC';
}

Any idea why this is impacting the other Views?

Regards
Pat

[Shane]

Hi Pat,

Thank you for contacting our support forum.

The reason why this is occurring is because of this line.

if ( $view_id != 98 ){

What this line is saying is that it's going to apply the code to every view except view 98.

What you need to do is to tell the code to target the exact view you want it to apply to so you will do it like this.

if ( $view_id == 98 ){

This allows it to target only view 98.

Please let me know if this helps.
Thanks,
Shane

[Pat]

Hi Shane,
Thanks for your return.
Unfortunately, this is not helping a lot. I had already tested this solution and retry just now. The result is the same and my second Views is still returning "no items" due to this sorting function.
If you look at the code I sent, the if ( $view_id != 98 ){ does not refer to the function but only to a single return (in order to apply the function only to Views 98. This was the code in the ticket you sent me).

Regards
Pat

[Shane]

Hi Pat,

Would you mind if I took a look at this for you ?

The private fields will be enabled for your next response. Also please let me know the page that this view is being used on.

Thanks,
Shane

[Shane]

Hi Pat,

Thanks for the credentials.

Could you let me know which one of the view is having the issues as well as where is the code that does the filtering.

Thanks,
Shane

[Pat]

Hi Shane,

The Views that is linked to the sorting function has the ID 98. The other Views is managing the slider in the home page.
The Views ID 98 is displayed in the aaa page.
Regards
Pat

[Shane]

Hi Pat,

Thanks and I took a look at this for you and it should be fine now.

Please let me know if this helps.
Thanks,
Shane

[Pat]

Hi Shane,

You're right, both sliders are working fine now. Can you tell me what was the issue (in order not to make it in the future !)
Thanks
Pat

[Shane]

Hi Pat,

Take a look at the code below.

This is what was there.

 add_filter('wpv_filter_query', 'add_custom_fiels_to_view_query', 99, 3);
function add_custom_fiels_to_view_query($query_args, $view_settings, $view_id ) {
    if ( $view_id == 98 ){

 
       $meta_query = array();
       $meta_query[] = array('key' => 'wpcf-jour-cours');
       $meta_query[] = array('key' => 'wpcf-heure-debut-cours');
	   $meta_query[] = array('key' => 'wpcf-minute-debut-cours');
       if ( !isset($query_args['meta_query']) ){
            $query_args['meta_query'] = array();
       }
       $query_args['meta_query'] = array_merge($meta_query, $query_args['meta_query']);
       add_filter('posts_orderby', 'custom_order');
 return $query_args;

	}

}

This is what it should've been

 add_filter('wpv_filter_query', 'add_custom_fiels_to_view_query', 99, 3);
function add_custom_fiels_to_view_query($query_args, $view_settings, $view_id ) {
    if ( $view_id == 98 ){

 
       $meta_query = array();
       $meta_query[] = array('key' => 'wpcf-jour-cours');
       $meta_query[] = array('key' => 'wpcf-heure-debut-cours');
	   $meta_query[] = array('key' => 'wpcf-minute-debut-cours');
       if ( !isset($query_args['meta_query']) ){
            $query_args['meta_query'] = array();
       }
       $query_args['meta_query'] = array_merge($meta_query, $query_args['meta_query']);
       add_filter('posts_orderby', 'custom_order');

	}
 return $query_args;

}

Notice the return statement is outside of the if statement.

This is needed in the even that the view id doesn't match. The previous function wasn't returning anything hence why your other views were being affected.

This filter should return something by default.

Thanks,
Shane

[Pat]

Hi Shane,

Understood
Thanks for your support
Regards
Pat