[Fixed in next Release] Would like to report few bug/usability issues

[Author]

Posts

[smileBeda]

Hello, I was working on a website today where toolset is a perfect match. Nice, for once 🙂

I saw 2 things during the process I wanted to report I believe can be fixed easily and will bring nice improved workflow.

1. When you have View names that are too long then the View name disappears in the selector of the View block when choosing a View, as well as in the Block Inspector.
This is a problem specially when you have several Views with the almost same name but their end (of the name) is different. Then, when inserting Views with Blocks you can never be sure if you inserted the right View.
See Screenshot "View cannot be specifically chosen" and "Block inspector also does not show full title" for this issue.
It is of course just a usability issue, but I think, for example a (VERY SIMPLE) title tag in the HTML would resolve this issue, so we could hover a moment with the mouse and see the actual full title, avoids a save, check, correct, save, check process.

2. CRED "Delete Post Link" Does not take any form of valid HTML as "Link Text". It is a short code we can insert with the GUI (I refer to legacy here, but I believe it is somehow similar in blocks) that will allow us to delete the post with CRED Features. It is called "Delete Post Link" and can be found in the CRED/Toolset Forms GUI for example in Content Templates.
Now, it is a enclosing short code ([shortcode][/shortcode]) and I believe by nature those should expand whatever HTML is enclosed - but this short code does not.
See in the screen shot "Cred Delete link does not accept HTML" what happens when I insert a simple "strong" tag, the strong gets printed as HTML instead of resolving.
This is a BUG, it is easily solved by simply crafting our own "a href" links, but the shortcode is totally useless for me (unless of course I do not pass HTML in the "link text", which is very rarely the case, usually you will want to pass a SVG Icon here)

To illustrated on code, this works:

<a href="#" class="js-cred-delete-post" data-postid="[wpv-post-id]" data-action="trash" data-onsuccess="self">ANY HTML HERE</a>

This does not:

[cred-delete-post action='trash' onsuccess='self']ANY HTML HERE[/cred-delete-post]

Thanks for considering and fixing.

[Shane]

Hi Beda,

Good seeing you again.

Thank you for the detailed explanations on both issues you've noticed.

I've taken a look at the issues and posted them on P2 so that Nigel can have a look and open a YT ticket for this.

Thanks,
Shane

[smileBeda]

For the second issue, for what reason I am not sure in Toolset Forms file /cred-frontend-editor/application/models/shortcode/delete/post.php line 200 the developer passes the actual HTML thru esc_html()

esc_html() is ... well, it does actually escape HTML blocks.
This means a valid HTML line like so

$html = esc_html( '<a href="<em><u>hidden link</u></em>">A link</a>' );

becomes in the browser:

<a href="<em><u>hidden link</u></em>">A link</a>

instead of an actual link.

So, removing esc_html() of course will resolve this issue immediately.

Really not sure what the purpose is of escaping safe HTML (Safe because it is added in a Editor to which only safe users have access to...)

Easy enough fix, I think?

[Shane]

Hi Beda,

I've got some good news from the dev team. Juan was able to resolve both issues you've raised. I see where the fixed versions are Views 3.5 and Forms 2.6.7

Ofcourse i'm unsure of when exact date when these will be released, however the issues are fixed in the next release.

Thanks,
Shane