[Resolved] Warnings after PHP 7.3 update

[Author]

Posts

[toolset-dave]

Hello,

I get warnings in Edit Post Field Group after updating PHP to 7.3:

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in .../wp-content/plugins/types/vendor/toolset/types/includes/classes/class.types.admin.edit.custom.fields.group.php on line 1508

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in .../wp-content/plugins/types/vendor/toolset/types/includes/classes/class.types.admin.edit.custom.fields.group.php on line 1515

Warning: "continue" targeting switch is equivalent to "break". Did you mean to use "continue 2"? in ..../wp-content/plugins/types/vendor/toolset/types/includes/classes/class.types.admin.edit.custom.fields.group.php on line 1522

[Minesh]

Hello. Thank you for contacting the Toolset support.

Well - this is known issue to us and the fix will be shipped with the Types version 3.3 in the near future.

For now, you should try to use the workaround shared by our Devs with the following errata page:
=> https://toolset.com/errata/php-7-3-shows-warnings-about-continue-statement-in-types/

[toolset-dave]

Hello,

I have read about this in errata page before, but it´s not the same file.

Also the issue you linked https://toolset.com/errata/php-7-3-shows-warnings-about-continue-statement-in-types/ is labeled as Open, but was solved in Types version 3.2.6 (see https://toolset.com/download/toolset-types/#changelog - Fixed a PHP 7.3 warning about “continue” targeting a switch). I have also checked the files in current version of Types and the file which is placed in https://toolset.com/errata/php-7-3-shows-warnings-about-continue-statement-in-types/ as a patch, are the same files.

[Minesh]

Indeed, it looks like the same issue on another place as well.

Can you please share exact steps to reproduce the issue or few screenshots?

[toolset-dave]

It displays when I want to edit any Custom Fields Group, see attachment.

[Minesh]

Ok - thank you. I reported this issue for further debug to our next level support. I will ask you to share duplicator copy if needed.

Please hold on for further updates.

[Minesh]

Ok - I just got the reply that we need duplicator copy of your site.

More info:
=> https://toolset.com/faq/provide-supporters-copy-site/

I have set the next reply to private which means only you and I have access to it.

[Minesh]

Thank you for sharing duplicator package.

I report the issue in front of our Devs. Please hold on for further updates.

[Minesh]

I would just like to update you that fix for this issue will be shipped with next release of Types version 3.3 that is scheduled to release in a 2-3 weeks from now if all goes well.

[toolset-dave]

Is it safe to Edit Post Field Group now? Or I should wait for the next release?

[Minesh]

Well - you should go ahead and edit post field group and as acknowledge before the fix for this issue will be shipped with next release of Types version 3.3 which is currently in QA.

[toolset-dave]

I have tried to create new post field group, but I got an error immediately after clicking on Save Field Group, see attachment.

[Minesh]

Yes - that's expected result. As I acknowledged before that fix will be shipped with Types version 3.3 which is undergoing QA for now.

You should be able to saved/update the custom field group without any issues.

Please hold until the release of Types. I

[Minesh]

I would like to update you that Types version 3.3 is finally released that should help you to fix this issue.
=> https://toolset.com/download/toolset-types/#changelog

[toolset-dave]

My issue is resolved now. Thank you!