Hi Jamal, nice to talk with you...
The workaround makes it better, but I think there are some issues still.
Since there may be many views on a page one would need to address each views loop separately.
Otherwise, when you update the pagination of one view all other views also would get the trigger since having the same HTML classes.
Now, there would indeed be a way to address JS to only the view with ID equal to view_unique_id object property of data (as delivered by js_event_wpv_pagination_completed hook.
But that object property has issues.
It cost of times throws a undefined data error.
This is an older bug too, I recall it being around a while.
To trigger it, instead of the workarounds JS use this JS:
jQuery( document ).on( 'js_event_wpv_pagination_completed ready', function( event, data ) {
console.log(data);
updatePagination();
});
Reload the page with the View.
There is already a undefined in the console logged, which should never happen in the js_event_wpv_pagination_completed hook as that is supposed to trigger only once AJAX paginated.
Then if you actually do trigger pagination you'll see this logged:
{view_unique_id: 54183, effect: "slideh", speed: 500, layout: n.fn.init(1), filter: n.fn.init(1)}
Now that seems to be OK, but if you want to use that in our JS, you will need to get the view_unique_id property. Agreed?
Let's try
jQuery( document ).on( 'js_event_wpv_pagination_completed ready', function( event, data ) {
console.log(data.view_unique_id);
updatePagination();
});
(Please let me know if my JS has a flaw, but data.view_unique_id or data['view_unique_id'] should really give us the object's property, if I am not totally wrong?)
Reload page
Due to thejs_event_wpv_pagination_completed being fired anyway even if we did not AJAX, now you get a fatal JS error Uncaught TypeError: Cannot read property 'view_unique_id' of undefined, which makes the pagination disappear, so you can't even trigger it anymore.
Hence, it is impossible to check if you are on a current view with that hook, and hence, the hook destroys all other views on page and the only way to solve that, is hardcoding unique Classes for each View on page with pagination.
For now, it's a workaround, but it's also a reason why one could not really "sell" this solution to a potential customer, as it needs maintenance and eventually is wrong. Just think of how many printed JS styles the page source for example will produce with this solution, which is also not ideal.
Additionally even hardcoding the IDs to target and having unique JS function names to trigger, if you have several views on page, triggering the AJAX in one view does trigger it on the other views too, making the pagination disappear. Somehow, it is all quite unstable.
Being this solution not applicable to Blocks at all, I am a bit at a loss to find other things in Views/Blocks that are "unique" and cannot be done in other, more stable plugins.
I mean, currently we clearly can't paginate in a modern way, there is additionally a bug that removes query filters from block views once you save the view (please let me know if you need a ticket about this but I am quite sure I personally already reported that back in time to your internal tracker 😉 )...
Basically I cannot filter, or paginate a Blocks View or View at all, without severe workarounds or compromises and even so, it is still not perfect
Pleas understand, I am not trying to rant, I just see that this a basic feature that makes Toolset stand out amongst other plugins:
The creation of a dynamic loop.
However, if it's broken, why would we use it?
And that is unfortunately one of the only features left unique to Toolset, because to be honest, (hate) Elementor is doing many of the things better meanwhile (Like forms, templating, even loops and queries).
You know that I bleed and dream and fan for Toolset and Toolset only, but this is getting somehow very hard to do 🙂
Are these issues handled with some priority?
I think these things are the ,strength of Toolset! It is sad they are not properly working out of the box.
Summary of Addon issues
- js_event_wpv_pagination_completed fires even if AJAX is not triggered
- data.view_unique_id throws errors
- Query filters in Blocks Views are deleted from the GUI after save + reload
