The issue was you have added the form in to the loop so the button names are dynamic.
I've adjusted the code you added to your "cred_save_data" hook added to your plugins file:
add_action('cred_save_data', 'lk_create_these_probant_intermediary',99,2);
function lk_create_these_probant_intermediary ($post_id, $form_data) {
$forms = array( 212 );
if ( in_array( $form_data['id'], $forms )) {
// id of probandt and these
$id_probant = $_POST['probandt-id'];
$id_these = get_the_ID();
$found_agree = array_search("agree",$_POST);
$found_disagree = array_search("disagree",$_POST);
if(!empty($found_agree)) {
$clicked_button = $_POST[$found_agree];
}else if(!empty($found_disagree)){
$clicked_button = $_POST[$found_disagree];
}
// whethter the probant agrees or disagrees with the given thesis - depending on the button, that he has clicked to submit the form
$probant_n_p = '';
if ($clicked_button == 'disagree' ) { $probant_n_p = 'n';} // form_submit_disagree => Disagree-Button
if ($clicked_button == 'agree') { $probant_n_p = 'p';} // form_submit_agree => Agree-Button
// search if a connection between this probant and the thesis already exist
$query = new WP_Query(
array(
'post_type' => 'probant-these',
'posts_per_page' => -1,
'toolset_relationships' => array(
array(
'role' => 'intermediary',
'related_to' => $id_probant,
'role_to_query_by' => 'parent',
'relationship' => 'probant-these'
),
array(
'role' => 'intermediary',
'related_to' => $id_these,
'role_to_query_by' => 'child',
'relationship' => 'probant-these'
)
),
//'meta_key' => 'wpcf-genre',
//'orderby' => 'meta_value',
//'order' => 'ASC',
)
);
$intermediary_posts = $query->posts;
$loop_iteration = 1;
//if it returns some posts
if($intermediary_posts){
//now get the single posts fields values
foreach($intermediary_posts as $intermediary ){
//get each Posts post data
$intermediary_post_data = get_post($intermediary);
//get each ID
$intermediary_post_id = $intermediary_post_data->ID;
//get each posts field value
if ($loop_iteration == 1) {
//------------------------------------------------------ first loop interation
// Update intermediary -- insert new values
$intermediary = array(
'ID' => $intermediary_post_id,
'meta_input' => array (
'wpcf-these-n-p' => $_POST['these-n-p'],
'wpcf-probant-n-p' => $probant_n_p,
'wpcf-these-zahl' => $_POST['these-zahl'],
'wpcf-these-position' => $_POST['these-position'],
'wpcf-these-zufall' => $_POST['these-zufall'],
),
);
// Update intermediary -- execute update
wp_update_post ($intermediary);
// increase $loop_iteration by 1
$loop_iteration += 1;
} else {
//------------------------------------------------------ if there is more than one intermediary -> delete it
wp_delete_post( $intermediary_post_id, $force_delete = true);
// increase $loop_iteration by 1
$loop_iteration += 1;
}}} else {
//------------------------------------------------------ if both pots are not related/connected with each other yet
//make new connextion and new intermediary
//connect Probant and These
$relationship_response = toolset_connect_posts(
$relationship = 'probant-these',
$id_probant,
$id_these
);
$intermediary_post_id = $relationship_response['intermediary_post'];
// Update intermediary -- insert new values
$intermediary = array(
'ID' => $intermediary_post_id,
'meta_input' => array (
'wpcf-these-n-p' => $_POST['these-n-p'],
'wpcf-probant-n-p' => $probant_n_p,
'wpcf-these-zahl' => $_POST['these-zahl'],
'wpcf-these-position' => $_POST['these-position'],
'wpcf-these-zufall' => $_POST['these-zufall'],
),
);
// Update intermediary -- execute update
wp_update_post ( $intermediary );
}
}
}
The part that is changed to check the clicked button is as given under with reference to above code:
$found_agree = array_search("agree",$_POST);
$found_disagree = array_search("disagree",$_POST);
if(!empty($found_agree)) {
$clicked_button = $_POST[$found_agree];
}else if(!empty($found_disagree)){
$clicked_button = $_POST[$found_disagree];
}
// whethter the probant agrees or disagrees with the given thesis - depending on the button, that he has clicked to submit the form
$probant_n_p = '';
if ($clicked_button == 'disagree' ) { $probant_n_p = 'n';} // form_submit_disagree => Disagree-Button
if ($clicked_button == 'agree') { $probant_n_p = 'p';} // form_submit_agree => Agree-Button
Can you please check now. It should be working as expected now.
