[Closed] Random and invalid and tags.

[Author]

Posts

[martijnH]

Hello Toolset,

We've encountered a bug in toolset (3.6.1) we know it's legacy.
On the page hidden link toolset generates false `</p>` tags.
As seen on the W3 validator: hidden link
We loop over a cpt to create this faq page but the first template for this View is rendered different from other.

The code for the content of the Loop Editor is:

[wpv-layout-start]
	[wpv-items-found]
      <!-- wpv-loop-start -->
        <wpv-loop>
          [wpv-post-body view_template="loop-item-cpt-veelgestelde-vragen-accordion"]
        </wpv-loop>
      <!-- wpv-loop-end -->
	[/wpv-items-found]
	[wpv-no-items-found][/wpv-no-items-found]
[wpv-layout-end]

The code for the Template is

	<!-- start div.card -->
	<div class="card">
	    <div class="card-header" id="heading-[wpv-post-slug]">
	        <h3 class="mb-0">
	            <button class="faq collapsed" type="button" data-toggle="collapse" data-target="#collapse-[wpv-post-slug]" aria-expanded="true" aria-controls="collapse-[wpv-post-slug]">
	              <i class="faq-icon fal fa-angle-down"></i> [wpv-post-title]
	            </button>
	        </h3>
	    </div>
	    <div id="collapse-[wpv-post-slug]" class="collapse" aria-labelledby="heading-[wpv-post-slug]" data-parent="#accordion-[wpv-taxonomy-slug id='$parent']">
	        <div class="card-body">[wpv-post-body view_template="None"]</div>
	    </div>
	</div>
	<!-- end div.card-->

Only in the first loop of this template toolset adds a few `</p>` on invalid places. But it also wraps the html comments (which I only added for this ticket) in a full <p><!-- comment --></p>

In the second render of the loop this does not happen.
What is going on here?

I've also tried putting an other cpt-item first the same thing happens at the first position. So It's not the cpt-item.

[Waqar]

Hi,

Thank you for contacting us and I'd be happy to assist.

Can you please include suppress_filters="true" attribute in the view's "wpv-post-body" shortcode and see if it has any affect?
( ref: https://toolset.com/documentation/programmer-reference/views/views-shortcodes/#wpv-post-body )

[wpv-post-body view_template="loop-item-cpt-veelgestelde-vragen-accordion" suppress_filters="true"]

regards,
Waqar

[martijnH]

Hi Waqar,

adding it does change something. Now the problem is on every loop, not just the first.....
So that is not the fix.

[Waqar]

Thanks for writing back.

Now, when I check the page's code or its validation, I'm not seeing those extra p tags.

Have you made any changes after writing to us and are you still seeing those extra tags? I'll recommend testing this again, after clearing all involved caches.

In case the issue still persists, you're welcome to share temporary admin login details, along with a few screenshots of where exactly those tags are showing.

Note: Your next reply will be private and it is recommended to make a complete backup copy, before sharing the access details.

[martijnH]

We are having an accessibility audit this week. So we applied a dirty fix.

I'll get back to you next week.

[Waqar]

Thanks for the update and please take your time.

I'm setting your next reply as private again, so that you can share the temporary admin access details when the audit is complete.