[Resolved] Number will increment when editing post “Auto Numbering Posts”

[Author]

Posts

[JosV9233]

I have incorporated an incremental number in a post (see: https://toolset.com/forums/topic/auto-numbering-posts/). This works fine, except when I edit the record, then the number will increment also.
How can I stop this and only have this number assigned on creation?

Menu to follow is admin > zoeken. Then click on an order no. In the content template click edit. After saving this the number has incremented.

The code I used is:

/**
* Add an auto-incrementing ordernummer field to telorder posts
*/
function auto_assign_ids( $post_id, $post, $update ) {

// Only assign ID to new telorder posts
if ( $post->post_status == 'publish' && $post->post_type == 'telorder' ) {

// get the most recent telorder post
$telorder_args = array(
'numberposts' => 2,
'post_type' => 'telorder',
'orderby' => 'post_date',
'order' => 'DESC'
);
$telorders = get_posts( $telorder_args );

// get the project_id of the prior post
$last_id = get_post_meta( $telorders[1]->ID, 'wpcf-ordernummer', true );

if ( !$last_id ) {
$last_id = 0;
}

// increment
$last_id++;

// set the project_id of the current post
update_post_meta( $post_id, 'wpcf-ordernummer', $last_id );

}
}
add_action( 'save_post', 'auto_assign_ids', 100, 3 );

[Minesh]

Hello. Thank you for contacting the Toolset support.

You can wrap all your code by adding if condition to check $update is true or false.

You should try to use following code and try to resolve your issue.

function auto_assign_ids( $post_id, $post, $update ) {

if($update == false) {

// Only assign ID to new telorder posts
if ( $post->post_status == 'publish' && $post->post_type == 'telorder' ) {

// get the most recent telorder post
$telorder_args = array(
'numberposts' => 2,
'post_type' => 'telorder',
'orderby' => 'post_date',
'order' => 'DESC'
);
$telorders = get_posts( $telorder_args );

// get the project_id of the prior post
$last_id = get_post_meta( $telorders[1]->ID, 'wpcf-ordernummer', true );

if ( !$last_id ) {
$last_id = 0;
}

// increment
$last_id++;

// set the project_id of the current post
update_post_meta( $post_id, 'wpcf-ordernummer', $last_id );

}
}
}
add_action( 'save_post', 'auto_assign_ids', 100, 3 );

More info:
=> https://codex.wordpress.org/Plugin_API/Action_Reference/save_post

[JosV9233]

Hi Minesh,
Thank you for your quick reaction. Unfortunately on new orders it will not give an order number anymore.

[Minesh]

Well - I just shared the information how you can check if you are updating the post or adding a new one.

If $update is true - that means you are updating existing post, and at that time you dont wanted to run that script - correct? If yes: thats the only change I've made and guided you about.

Regarding where you want to display something and whats not working - could you please give me exact information whats not working with all the workflow. I would be happy to help you further.

[JosV9233]

Hi Minesh,
I can see what you changed and do not understand why it does not work anymore.
To test I put back the old code and it worked again. Then I manually put in the [if($update == false) {] and the [}] in the right places without the [] and it stopped working.
I want to output an incremental number in a custom post type. I can send you login to check yourself.

[Minesh]

Could you please tell me where you are displaying the field?

Also send me working FTP access details.

[Minesh]

Unfortunately - the wp-admin access details you shared is not working as this end.

Could you please resend working wp-admin and FTP details.

I have set the next reply to private which means only you and I have access to it.

[Minesh]

Thanks wp-admin access details are working now but still FTP access details are not working.

Could you please resend it.

[Minesh]

FTP access details still not working. Do I need to use any port?

[JosV9233]

> domains > zz6.nl > public.html > v-web

[Minesh]

Ok - finally - FTP access working now.

Could you please point me the URL where you are displaying the field?

I can see view is added on this page: hidden link and it's displaying the order number: