[Resolved] Number will increment when editing post “Auto Numbering Posts” vs2

[Author]

Posts

[JosV9233]

Christian,

Please read about my problem in this post: https://toolset.com/forums/topic/number-will-increment-when-editing-post-auto-numbering-posts/

I could not get it resolved there and decided to open a new ticket as I was not getting anywhere with that supporter. His first answer is to the point but for some reason that did not solve the problem. From there on it became a disaster as if he was not even reading his own answers anymore.

I hope you can solve this.

[Christian Cox]

Hi, I think the problem is that the post_status isn't publish on the first auto save, so the conditional here is blocking the rest of the code:

if ( $post->post_status == 'publish' && $post->post_type == 'telorder' ) {

Change it to this:

if ( $post->post_type == 'telorder' ) {

Let me know if this does not resolve the issue and we can take a closer look.

[JosV9233]

No, did not work. The first new entry gave a blank 'ordernummer', the second one gave 1 and the third one gave als 1.

Editing the order did not increment the number, so that's already good.

Tell me if you need logins for admin and ftp.

[Christian Cox]

Okay I tested this out and it seems to be working more consistently now:

/**
* Add an auto-incrementing ordernummer field to telorder posts
*/
function auto_assign_ids( $post_id, $post, $update ) {
  if( $update == false ) {
    // Only assign ID to new telorder posts
    if ( $post->post_type == 'telorder' ) {

      // get the most recent telorder post
      $telorder_args = array(
      'numberposts' => 1,
      'post_type' => 'telorder',
      'orderby' => 'post_date',
      'order' => 'DESC'
      );
      $telorders = get_posts( $telorder_args );

      // get the project_id of the prior post
      $last_id = isset($telorders[0]) ? get_post_meta( $telorders[0]->ID, 'wpcf-ordernummer', true ) : 0;

      // increment
      $last_id++;

      // set the project_id of the current post
      update_post_meta( $post_id, 'wpcf-ordernummer', $last_id );

    }
  }

}
add_action( 'save_post', 'auto_assign_ids', 100, 3 );

I modified the logic for determining the most recent post. Please create at least one new post and manually set the ordernummer value to be some number greater than the other ordernummers. Then when you create the next new post, it should be automatically set correctly. Future updates will not modify the ordernummer field.

[JosV9233]

Hi Christian,

It seems to be working fine. The number increments with new orders and stays the same after an edit. I will test it some more, but I believe you solved the problem.

Very nice!

Regards,
Jos

[hpJ]

This works perfectly! Thank you.