[Resolved] Arguments in types_render_field() are ignored since Types v3.x

[Author]

Posts

[Matthias]

Hi,

I have set up some custom fields and outpout these in my theme like this:

<div class="ad-details">
    <?php echo types_render_field( "plz", array( "output" => "html", "show_name" => "true" )); ?>
    <?php echo types_render_field( "ort", array( "output" => "html", "show_name" => "true" )); ?>
    <?php echo types_render_field( "telefon", array( "output" => "html", "show_name" => "true" )); ?>
</div>

Since Version 3.x the arguments are ignored. The wrapping HTML Tags for field name and field value are missing. The functions just outputs the raw value. See the screenshots.

Best regards
Matthias

[Nigel]

Hi Matthias

I tested this locally and confirm the problem.

I have escalated this so that my colleagues can identify the cause so that it can be fixed, and I'll update you as soon as I have any news.

[Nigel]

Hi Matthias

Just to let you know this was fixed with an update to Types 3.0.2 earlier this week.

If you have updated already you will hopefully have noticed the update.

[Matthias]

Hello Nigel,

thank you for the info. I updated the plugin but the field names (argument "show_name") are still missing. See the new screenshot.

Best
Matthias

[Nigel]

Hi Matthias

It is not documented that you can use the show_name argument (https://toolset.com/documentation/customizing-sites-using-php/functions/), but is it something that used to work for you which stopped working in Types 3?

I can see that it doesn't work, but what is unclear is whether it is expected to work or not.

If you can confirm a Types version where it used to work, please let me know the version number, and the kind of Types field you are using.

I can then escalate this as a bug.

If you would like it to work but it never did work, then I'll handle it as a feature request.

[Matthias]

Hi Nigel,

it works in Types 2.3.2. I use a simple text field here. See another screenshot.
For the code in my theme and a screenshot of the output see my first post in this thread.

Cheers,
Matthias

[iainF]

Hi

I'm having exactly the same problem and I've now got a customer site that is missing a lot of labels on the reports.

It's worked fine for years, and it used to be in the documentation (or I wouldn't have found it). You have shown people in the forums how to use "show_name" in the past as well: https://toolset.com/forums/topic/hide-field-label-from-when-using-show_name-true-attribute-in-types/

It needs to be put back in as a matter of urgency.

Regards

Iain

[Nigel]

Hi Matthias

You are right, I checked and it works pre-Types 3.

However, it is not documented, but in any case I'm escalating this so that the developers can take a look and see why it stopped working with the changes in Types 3.

Note that as a workaround you can, of course, simply insert text ahead of the field value directly in the PHP template.

[Nigel]

Hi Iain

I've just seen your comment, and it's duly noted, this will be raised at the developer meeting Monday morning.

[iainF]

Thanks Nigel.

I've also tried using the "output"=> "html" parameter, as this was supposed to add the field label. This doesn't seem to work either.

I've spend a while looking at the source code, and I notice that types_render_field has internally been replaced with types_render_postmeta which doesn't have the same functionality.

Regards

Iain

[Nigel]

Our devs revisited this, and whereas the show_name attribute was available somewhat arbitrarily on some types of custom fields but not others, it has now been updated to work on all fields where it makes sense.

We released Types 3.0.6 yesterday with this fix. Please update and let me know if you still have problems with it.

[Matthias]

Hello Nigel,

thank you for the update.

The field name is back but unfortunately, it's not wrapped in a <span>-Tag as in version 2.3.2. Please see the screenshot in my 1st post in this thread: hidden link

The HTML tags looked like this in all version < 3.x:

<div id="wpcf-field-XYZ" class="wpcf-field-textfield wpcf-field-XYZ">
	<span class="wpcf-field-name wpcf-field-textfield wpcf-field-XYZ-name">XYZ:</span>
	<span class="wpcf-field-value wpcf-field-textfield-value wpcf-field-XYZ-value">some value</span>
</div>

In version 3.0.6 the field name is outside the wrapping div and it's not wrapped in a span.

Best regards,
Matthias

[Nigel]

You are correct, when used in conjunction with the output="html" attribute the markup is not correct.

I'm guessing it was tested in isolation and not in that combination.

I have re-opened the internal ticket and asked the developers to look again.

[Nigel]

Matthias

They took another look at this and the show_name attribute should work correctly when used in combination with output="html" in the next version of Types.

In the meantime a patch is available as described here: https://toolset.com/errata/types-fields-are-not-displayed-properly-using-types_render_field/

Sorry for the inconvenience.

[Matthias]

The patch fixes the problem. Thank you for your help, Nigel!