Hi Dee,
Nigel will be away on vacations until next week, and I'll be following up on this ticket.
The way PHP works, the difference in the performance of both approaches (A & B) should be unnoticeable, however, I'll prefer the approach A, because:
1. The code will be cleaner/tidier to manage.
2. You won't be adding multiple functions and actions to call different conditions.
As for the screencast related to the "Plugin Load Filter" Plugin, it is not entirely clear exactly how the template, theme and other plugins are configured to work on the page in question. But other Toolset plugins rely on the Toolset Types plugin, not only for the common resources ( CSS & script files ) but also in some cases for PHP code.
I'm afraid, it is not possible to troubleshoot this without access to that webpage, in the state when Types plugin is disabled, but to start troubleshooting, I would recommend checking the browser's console to see if there are any errors or warnings recorded when Toolset Types is disabled.
( ref: https://wordpress.org/support/article/using-your-browser-to-diagnose-javascript-errors/ )
>> I also would like to check is it safe to disable "toolset-access" on non-toolset pages?
- Since the Toolset Access plugin manages critical functions like user roles and their capabilites and then grant or deny access to particular pages/sections accordingly, a general recommendation would be against this.
However, this primarily depends on how and specifically what features of the Toolset Access plugin are being used on the website. For example, suppose that you have registered a new user role through Toolset Access or are controlling customized access capabilities for the default WordPress user roles. Since, both these are global operations and are not limited to a some pages, this can lead to unexpected results or security/access loop holes, even if the plugin is disabled on page(s) where apparently there are no Toolset components being used.
I hope this helps and please let me know if any point is not clear.
For a new question/concern, please open a new ticket.
regards,
Waqar