[Resolved] Views not loading properly

[Author]

Posts

[michaelO-8]

I am trying to:

When loading a view I have used for a while, the loop does not display anymore. It should display a loop of custom posts that the author has created. It works on the live site, but not the dev site anymore. I checked for compatibility issues by disabling other plugins and using a standard wordpress theme, but the issue is persisting. Not much has changed on the site other than I updated toolset to the most recent versions recently, but I think it was working properly when I first updated it. I have included a link to a duplicator package below, but if you cannot reproduce the issue, I will provide site access.

For the loop, it does not say that no posts can be found--it just does not load anything within the loop, even if changes are made.

Link to a page where the issue can be seen: hidden link

I expected to see: A list of custom posts "booths" made by the author.

Instead, I got: nothing, not even no results found.

[Christian Cox]

Hi, I installed the site locally using your Duplicator package and logged in as the "toolset" user. I created one Booth post as a test, and now when I hit the /my-company-page-standard-view/ page I see that Booth post in the View (see the screenshot). So I'm not really sure what the problem could be. Are you logging in as a specific user? If so, can you share the login credentials so I can check the page as that User?

[michaelO-8]

Hi Christian,

I also noticed something odd, the view for the page: hidden link seems to work for me, but when putting that view in another page, such as the page:hidden link, the same view seems to stop working.

[michaelO-8]

Hi Christian,

Sorry it does seem you are right, the view seems to work correctly for the toolset user. Can you try the user "wsue"?

Thanks!

[Christian Cox]

I'm testing user wsue on my local and I'm able to see one result appear in the View. I'm attaching a screenshot of the /my-company-page-standard-view/ page here. I also tested creating a new Page and placing the my-company-page-maryville View on that page. The results are identical. There must be something else going on. Is it possible there is some caching system in place on one of your live environments? That could be a caching plugin in wordpress, or a server-side caching system like Object cache, memcached, varnish, etc? If so, can you clear that cache?

Are you using the User switching plugin to test the wsue User, or actually logging in? If you're using the plugin, can you try actually logging in instead?

Edit: I should mention I was testing User wsue by manually changing their password in the local database.

[michaelO-8]

Hi Christian,

It definitely seems like a caching issue, I just can't figure out what would cause it. I did try logging as that user, not switching and the issue persists. Have you tried logging into the site and switching as that user or have you poked around? I am at a loss as to what could be the cause or how to potentially clear the cache.

[Christian Cox]

You can try disabling Views cache first. You can do that by modifying the View shortcode like so:

[wpv-view name="your-view-name" cached="off"]

If that doesn't work, I can login and take a look. Please provide login credentials for some admin User here. I've been using my local environment and setting passwords manually as needed.

[Christian Cox]

Thanks, I'll test and get back to you as soon as I can.

[Christian Cox]

Okay I see the problem now. There is a custom code snippet interfering with this View. Please go to Toolset > Settings > Custom Code tab and find the snippet "view-dashboard-day" on page 2. Inactivate the snippet and you can test again as wsue to see the View return one result.

I see several issues in this code that need to be resolved.

add_filter( 'wpv_filter_query_post_process', 'show_day' );
 
function show_day( $query) {
     $post_type = get_post_type();
  if($view_id= 34308 && $post_type == "page"){

There is no variable $view_id, and instead of checking for equality you are assigning a value to a variable instead. A double equal sign is required to check equality. Similarly, in the second conditional block:

if($view_id= 34338 && $post_type == "page"){

Again, you are assigning a value to the $view_id variable instead of testing for equality.

Most likely you need to adjust the add_filter line to tell the filter to expect more parameters:

add_filter( 'wpv_filter_query_post_process', 'show_day', 99, 3 );

Then in the function definition, add two expected callback parameters:

function show_day( $query, $view_settings, $view_id ) {

Now in the conditionals, you have access to the $view_id callback parameter as a variable. Be sure to use double equals signs to test equality:

if($view_id == 34308 && $post_type == "page"){

if($view_id == 34338 && $post_type == "page"){

Those are the issues I see at first glance, but you may want to do a more thorough investigation in to this custom code snippet to ensure it works as expected.

[michaelO-8]

Hi Christian,

Thank you! I apologize, apparently we had been keeping this snipped deactivated and someone activated it again only recently for testing purposes. I didn't realize this so it didn't occur to me that the custom code could be the issue.

I do have a couple of questions:

1. This code doesn't seem have anything to do with the view that wasn't working, is there a reason why this code would conflict with it?

2. There are definitely some syntax errors in there, but when pressing "save and test", Toolset gives the message "The snippet has been re-run without errors." Does Toolset not check for these kind of errors?

Thanks!

[Christian Cox]

1. This code doesn't seem have anything to do with the view that wasn't working, is there a reason why this code would conflict with it?
The conditionals are not logically sound, so the code included in those two conditionals is incorrectly applied to some Views where it should not be applied. In other words the code included in these two conditionals would be executed for any View included on any Page, not only the two Views with those specific IDs. That's the gist of the problem - the conditionals are not accurate and the code is being applied too broadly. The conditionals need to be changed to narrow the scope where this code is applied.

2. There are definitely some syntax errors in there, but when pressing "save and test", Toolset gives the message "The snippet has been re-run without errors." Does Toolset not check for these kind of errors?
There are no actual syntax errors here, I'm afraid. Since you were assigning some value to the $view_id variable with the single equals sign, no syntax errors related to undefined variables would be thrown. It's a sneaky typo that has unintended side effects.

[michaelO-8]

Thank you so much, I really appreciated it! I'll be on the lookout for these kinds of issues going forward.