[Resolved] Views layout cannot be saved after update

[Author]

Posts

[takoL]

I am trying to:
Edit and save a view layout.

I expected to see:
Message: vies updates / alle sections saved

Instead, I got:
loading spinner but nothing happens
with error in console:
Uncaught ReferenceError: dataholder is not defined
at Object.self.save_section_content [as callback] (views_editor.js?ver=2.7.3:4034)
at HTMLDocument.<anonymous> (views_editor.js?ver=2.7.3:846)
at HTMLDocument.dispatch (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-&load[]=ui-button,jquery-ui-position,jquery-ui-dialog,jquery-ui-tabs,suggest,underscore,shortcode,wp-util,wp-pointer,quicktags,wp-a11y,w&load[]=plink,backbone,jquery-effects-core,jquery-effects-size,jquery-effects-scale,jquery-ui-sortable,jquery-ui-tooltip,moxiejs,pluploa&load[]=d&ver=5.1:3)
at HTMLDocument.r.handle (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-&load[]=ui-button,jquery-ui-position,jquery-ui-dialog,jquery-ui-tabs,suggest,underscore,shortcode,wp-util,wp-pointer,quicktags,wp-a11y,w&load[]=plink,backbone,jquery-effects-core,jquery-effects-size,jquery-effects-scale,jquery-ui-sortable,jquery-ui-tooltip,moxiejs,pluploa&load[]=d&ver=5.1:3)
at Object.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-&load[]=ui-button,jquery-ui-position,jquery-ui-dialog,jquery-ui-tabs,suggest,underscore,shortcode,wp-util,wp-pointer,quicktags,wp-a11y,w&load[]=plink,backbone,jquery-effects-core,jquery-effects-size,jquery-effects-scale,jquery-ui-sortable,jquery-ui-tooltip,moxiejs,pluploa&load[]=d&ver=5.1:3)
at Object.a.event.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-&load[]=ui-button,jquery-ui-position,jquery-ui-dialog,jquery-ui-tabs,suggest,underscore,shortcode,wp-util,wp-pointer,quicktags,wp-a11y,w&load[]=plink,backbone,jquery-effects-core,jquery-effects-size,jquery-effects-scale,jquery-ui-sortable,jquery-ui-tooltip,moxiejs,pluploa&load[]=d&ver=5.1:8)
at HTMLDocument.<anonymous> (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-&load[]=ui-button,jquery-ui-position,jquery-ui-dialog,jquery-ui-tabs,suggest,underscore,shortcode,wp-util,wp-pointer,quicktags,wp-a11y,w&load[]=plink,backbone,jquery-effects-core,jquery-effects-size,jquery-effects-scale,jquery-ui-sortable,jquery-ui-tooltip,moxiejs,pluploa&load[]=d&ver=5.1:3)
at Function.each (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-&load[]=ui-button,jquery-ui-position,jquery-ui-dialog,jquery-ui-tabs,suggest,underscore,shortcode,wp-util,wp-pointer,quicktags,wp-a11y,w&load[]=plink,backbone,jquery-effects-core,jquery-effects-size,jquery-effects-scale,jquery-ui-sortable,jquery-ui-tooltip,moxiejs,pluploa&load[]=d&ver=5.1:2)
at a.fn.init.each (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-&load[]=ui-button,jquery-ui-position,jquery-ui-dialog,jquery-ui-tabs,suggest,underscore,shortcode,wp-util,wp-pointer,quicktags,wp-a11y,w&load[]=plink,backbone,jquery-effects-core,jquery-effects-size,jquery-effects-scale,jquery-ui-sortable,jquery-ui-tooltip,moxiejs,pluploa&load[]=d&ver=5.1:2)
at a.fn.init.trigger (load-scripts.php?c=0&load[]=jquery-core,jquery-migrate,utils,jquery-ui-core,jquery-ui-widget,jquery-ui-mouse,jquery-ui-resizable,jquery-ui-draggable,jquery-&load[]=ui-button,jquery-ui-position,jquery-ui-dialog,jquery-ui-tabs,suggest,underscore,shortcode,wp-util,wp-pointer,quicktags,wp-a11y,w&load[]=plink,backbone,jquery-effects-core,jquery-effects-size,jquery-effects-scale,jquery-ui-sortable,jquery-ui-tooltip,moxiejs,pluploa&load[]=d&ver=5.1:3)

So: javascript breaks and views layout is not saved.
Important: edit and save filters / view loop works correctly. We only encounter this error when saving the view layout portion of the view edit screen.

[takoL]

PS. this issue occurs with view version 2.7.3

the issue does NOT occur with views version 2.7.2

[Nigel]

Hi there

This is a known issue: https://toolset.com/errata/after-updating-to-views-2-7-3-the-checkbox-for-disable-the-wrapping-div-around-the-view-does-not-work/

That erratum contains a patch, and there should be a Views hotfix release early next week that fixes this and other issues.

Sorry for the inconvenience.

[takoL]

Hi Nigel,

Thank you for the quick response.
The problem however still persists.
The quickfix that you mentioned does resolve the issue with the "Disable the wrapping DIV around the View" checkbox.
However it is still impossible to save any changes to the output editor.

See attached image.

Cheers,

Tako

[Nigel]

Sorry, you are right.

I just tested the same on a site where I had already applied the patch, and I still get the JS error when trying to save changes to the Output Editor.

I've passed that feedback to the Views developers, we'll need to make sure any fix covers this, too.

I'm escalating this and will keep you posted.

[Nigel]

OK, the patch in the erratum has been updated and I just tested it and confirm it works.

I did need to do a hard reload in my browser to make sure the new JS file is used, though, not the one in the browser cache.

Can you confirm?