Ok, I have some more information after MUCH debugging trial and error, but I could do with some clarification on a point or two and probably some help after all.
So I have validation hook calls in multiple snippets, and snippets are structured alphabetically obviously. So the first three examples of this are as follows:
adding_children_to_class_functions
class_edit_functions
custom_form_validations
And the issue I've noticed originates in the custom_form_validations file, as this contains all of the main basic form validations, and has over 300 lines of code in it, but all of the validations are written as one long ifelse under one function.
If all three snippets are active, the validation hooks in the first two function perfectly and the third (the main one) will not function (the validation literally does not appear to fire at all). If I disable the first two, then the third one starts working again, but if there is even a call to the cred_form_validate hook in either of those files with empty functions, absolutely zero code in the function, then the third file's validations will fail again. This really makes very little sense to me.
So I've tried taking the simplest validation from the function the main custom_form_validations file and isolating it, here is the stripped-back function in question:
function term_validations( $error_fields, $form_data ){
//Load list of field data comprised of field values and errors
list( $fields, $errors ) = $error_fields;
//uncomment this if you want to print the field values
//print_r($fields);
/** Validation for New Term form OR Edit Term form OR Edit Term Dates form **/
//if( $form_data['id'] == 446 || $form_data['id'] == 732 || $form_data['id'] == 1132 )
if( $form_data['id'] == 732 ){
/* Validation - Check the End Date comes after the Start Date */
if( $fields['wpcf-term-start-date']['value']['datepicker'] > $fields['wpcf-term-end-date']['value']['datepicker']){
//End Date error message
$errors['term-end-date'] = 'End Date must be greater than the Start Date';
}
//Return array of results
return array( $fields, $errors );
}
}
add_filter( 'cred_form_validate', 'term_validations', 10, 2 );
But the same pattern is true. It works in isolation, but not with the other hook calls active. I've moved it to a new snippet and it works fine by itself, but not with the other calls. I moved the, admittedly more complex, validation from the adding_children_to_class_functions snippet into the new file while leaving the original snippet inactive, and having the two validation calls again resulted in the above validation function not firing and the second one (see below) working fine, exactly as they had when in individual snippet files. Here is the code from the adding_children_to_class_functions snippet:
function add_child_to_class_validations( $error_fields, $form_data ) {
//Load list of field data comprised of field values and errors
list( $fields, $errors ) = $error_fields;
//uncomment this if you want to print the field values
//print_r($fields);
//Validation for Add Child to Class form
if ( $form_data['id'] == 1283 ){
//Get current class ID
$class = get_the_ID();
//Get number of children assigned to current class
$assigned_children = toolset_get_related_posts(
$class,
'child-class',
array(
'query_by_role' => 'parent',
'limit' => 999,
'offset' => 0,
'args' => array(),
'return' => 'post_id',
'role_to_return'=> 'child'
)
);
//Get number of children being added
$added_children = count( $_POST['select-children'] );
//Sum the total number of children this will be
$total_children = count( $assigned_children ) + $added_children;
//Get classes stored capacity
$capacity = get_post_meta( $class, 'wpcf-class-capacity', true );
//Check there is space in the class
if( $total_children >= $capacity ){
//Capacity error message
$errors['select-children'] = 'Sorry, this will exceed the classes maximum capacity of ' . $capacity;
//return result
return array( $fields, $errors );
}
//Loop through the children added
foreach( $_POST['select-children'] as $child ){
//If child is already in the array of children in the class
if( in_array( $child, $assigned_children ) ){
//Duplicate child error message
$errors['select-children'] = 'Sorry, ' . get_post_meta( $child, 'wpcf-child-first-name', true ) . ' ' . get_post_meta( $child , 'wpcf-child-surname', true ) . ' is already in this class.';
//return result
return array( $fields, $errors );
}
//Check to see if this child has available tokens
$child_tokens = toolset_get_related_posts(
$child,
'child-token',
array(
'query_by_role' => 'parent',
'limit' => 999,
'offset' => 0,
'args' => array(
'meta_key' => 'wpcf-token-status',
'meta_value' => 'Available',
'meta_compare' => '='
),
'return' => 'post_id',
'role_to_return'=> 'child'
)
);
//If available tokens are found
if( !empty( $child_tokens ) ){
if( isset( $_POST['all-classes'] ) ){
if( count( $child_tokens ) < count( get_class_group( $class, 'future' ) ) ){
$errors['select-children'] = token_error_message( $child, 'quantity' );
//return result
return array( $fields, $errors );
}
}
//Loop through each token
foreach( $child_tokens as $child_token ){
//If the token end date is NOT in the future (end date is smaller than current date)
if( get_post_meta( $child_token, 'wpcf-token-valid-until-date', true ) < strtotime( "now" ) ){
//Token error message
$errors['select-children'] = token_error_message( $child, 'status' );
//return result
return array( $fields, $errors );
}
}
//If no available tokens were found
} else {
//Token error message
$errors['select-children'] = token_error_message( $child, 'status' );
//return result
return array( $fields, $errors );
}
}
}
}
add_filter( 'cred_form_validate', 'add_child_to_class_validations', 10, 2 );
But as I've said, both of these validations work perfectly in isolation, and if they're both active the second one will always work fine and the first (which is a part of something much larger usually) will not work at all.
I have managed to make them both work at the same time by combining them into a single function and hook call by using the form ID's as an ifelse, but surely this just brings up more questions.
I've also tried changing the priorities on the hook calls, but it's made no difference.
I also have validation hook calls in another file called woocommerce_refund_functions, and having this validation hook active does not appear to affect the others, but the validation isn't 100% working right now as I've pulled it apart trying to figure this issue out, so I can't confirm if it can coexist or not at this point.
So from what I can see, it appears that it's not liking multiple validation hook calls being active. Is this a factor for Toolset? Is there a proper way of using multiple validation hook calls for Cred forms? Can it become an issue if several are in different files at once? It doesn't seem to make sense that I'd have to combine all validation calls into a single giant function for them to work as this isn't how hooks are designed to function.
If not, do you have any idea what else could be affecting this, as the forms only have the most basic of JS on them, just editing field rendering, the behaviour is consistent with just Toolset Types, Blocks, and Forms as active plugins and on the default theme.
I'd really appreciate some help debugging this further as at present it appears to be an issue with how Toolset is processing the cred_form_validate hook calls.
