[Resolved] Toolset Types 3.4.15 upgrade conflict with Advanced Post Types Order plugin

[Author]

Posts

[UP Entertainment]

I am trying to: upgrade to 3.4.15 without it impacting my Advanced Post Types Order plugin.

Link to a page where the issue can be seen: Video explainer here: hidden link (unlisted, so it's not public)

I expected to see: The ability to re-order movie content types within our website.

Instead, I got: The presets were removed and/or the Advanced Post Types Order plugin no longer works after upgrading Toolset Types to 3.4.15. When I rolled our site back -- which uses 3.4.5 -- it worked fine again.

I can grant FTP access / site access down the road if needed, but I'll wait to see if you have any thoughts in the meantime.

[Nigel]

Hi there

I tested a copy of the free version of the Advanced Post Types Order plugin with the current version of Types, and it appears to work as expected.

No problems re-ordering posts in the backend, and if I check the archive of posts on the front end the order is respected, and if I create a View of the posts, the order is also overwritten to match those manually applied in the back end.

So it looks like the issue is with the pro version. I checked our compatibility library and we don't have a copy of it. We can contact the plugin authors to request a copy for testing, but it would be quicker if you were able to just zip a copy and share it via dropbox or similar here so that we can see if we can reproduce the problem.

Can I ask how that carousel of movies at the top of the page is made? Is it using a View?

[UP Entertainment]

Here's the plugin (zipped): hidden link

And here's a key. Just let me know when you're done and I'll re-register it from our account
apto-license-3361f2f4-a54edff6-c6cfcb2d

As far as how the carousel is built/rendered, it's not a Toolset "View" (or whatever the plugin is called). The only Toolset plugin we use on UPtv.com is Toolset Types, but not the other / companion plugins.

I've uploaded some screenshots of code for that page, but I'm guessing I'll need to find the function for uptv_get_featured_movies

I'm not a developer... and unfortunately, the developer who coded this site departed when he became a first-time dad as he wanted to spend time with his new son. Since we had just finished launching the site (and really didn't need any maintenance), we parted ways... and that was about two years ago.

Let me know how else I can help... and thanks for the fast reply!

[Nigel]

Thanks for that. I've added it to my own test site and it doesn't appear to be re-ordering on the front end as intended. That's with Types 3.4.15 installed. I checked with an older version of Types and it did work, so I'll need to do some more testing to verify when exactly it broke, and what broke it.

I'll report back when I've done that.

[Nigel]

I may have spoken too soon.

I created a clean test site to work specifically on this issue, and it does appear to be working correctly (with the current version of Types).

So it seems I am not able to reproduce the issue after all.

In that case could I get access to a staging site where I can see the problem? I'll want to do some testing, and while I don't intend to make any changes that would break anything, it should be a site that is suitable for testing.

Let me mark your next reply as private so that I can get log-in credentials from you—you may want to create a temporary admin user for me to use that you can later delete.

[Nigel]

Hi Jason

I've been testing your staging site this morning, which has concluded with Types 3.4.15 being installed and the re-ordering working as expected.

I first confirmed it was working with the installed Types 3.4.5.

I clicked the link to update Types, which failed. (I didn't investigate this; I suppose the key was linked to the production URL rather than this staging site URL.)

So I manually updated, initially testing 3.4.6 and then several other versions before finally arriving at 3.4.15.

The first time I did that I de-activated Types first, and after re-activating the updated plugin found that the Advanced Post Type Order settings currently in use appear to have been lost. I went to recreate them, upon which a notice at the top indicated there was an existing re-order that would be used (i.e. the original re-ordering), and following that link I was able to resume working with the original re-ordering.

That didn't happen with subsequent Types updates, where I simply uploaded the plugin files to overwrite the existing install (through the Add New Plugins page), without first de-activating it.

Types is used to register the custom post types and taxonomies, and if it is deactivated (even temporarily) then Advanced Post Types Order can no longer reference them. Without digging into the exact steps, I think that is why the re-order settings are temporarily lost.

Anyway, as to the issue itself I didn't encounter any problems, the re-ordering continued to work with whatever version of Types I had installed, including up to Types 3.4.15.

That's the current state of the site, if you can verify that for yourself.

What is your workflow for updating production? Pushing changes from a staging server?

[UP Entertainment]

Nigel,

Thanks for the update. I was updating the ToolsetTypes plugin on the screen where it shows the available updates screen.

In the plugins screen, I'd click on "Registered" (as seen in step1.jpg)... and then it'd take me to the screen seen in step2.jpg, where I'd tick the box next to what I'd want to update... then tick "activate after download"... and click download.

So you're suggesting that if I download the plugin itself as a .zip file... and then upload it manually (as opposed to doing a plugin update) that it should work?

And our workflow for updating production is simply testing it on the staging server... and if it works, replicating the steps. I don't do an FTP push / GitHub push or anything like that.

Thanks again for your help. If you can confirm that you think I can get away with a manual upload, I'll try it on a staging server on my end.

Thanks!

[Nigel]

I didn't mean to suggest that the problem necessarily occurs because of using the update link from the plugins page, just documenting that I didn't go via that route, and that following the steps I took did leave the re-ordering plugin working intact.

Given the difficulty in reproducing and pinning down the cause, I'd suggest you try the following (first on a staging site, then production):

1. download an intermediate version of Types (e.g. version 3.4.10) from here: https://toolset.com/download/toolset-types/#changelog
2. on your site go to the Add New plugins page, use the Upload Plugin button and upload the zip archive you just downloaded. You'll have a few clicks to make to confirm you want to overwrite the existing plugin
3. do some tests to verify it still works as expected
4. try the same, but this time for the current version of Types, 3.4.15

Does the re-ordering still work as intended?

If there are problems with the above then the next thing I'd suggest as an alternative is to first disable the Advanced Post Types Order plugin, then update Types to the current version, then re-activate the ordering plugin.

Let me know how you get on.

[UP Entertainment]

Nigel,

Happy Wednesday!

This worked on staging -- going to .10... so then I went to .15. The bookmarks/presets were still there... and the re-ordering capability worked in both cases.

I did it on prod. Both times, I got very brief instances of site jumble (to be expected during file overwrites) and in the first attempt, I got an alert about the site experiencing a technical issue, but it automatically resolved itself.

So we now have the latest and greatest version on prod. The functionality seems to work as intended. Thanks for all of your help. You can close this ticket. 🙂