[Resolved] Select Author changes on update although no Author selected.

[Author]

Posts

[Nashaat]

Hi,
i am using followiing code to change author with cred form.

// Save Selected Author
add_action('cred_save_data', 'my_save_data_action_select_author',10,2);
function my_save_data_action_select_author($post_id, $form_data) {

  //create an array of values with all ID's of the Forms you want to check:
  $ids = array("8604","8598","8603","8599");
    
  //Check if the current form ID is one of in the above array:
  if (in_array($form_data['id'], $ids) ){
  
  
$my_post = array(
      'ID'           => $post_id,
      'post_author' => $_POST['my_autor_select']
  );
   
// Update the post into the database
  wp_update_post( $my_post );
 
}
}



// Clean View Output
  
add_filter( 'wpv_filter_wpv_view_shortcode_output', 'prefix_clean_view_output', 5, 2 );
      
function prefix_clean_view_output( $out, $id ) {
    if ( $id == '8650' ) { //Please adjust to your Views ID
        $start = strpos( $out, '<!-- wpv-loop-start -->' );
        if ( 
            $start !== false
            && strrpos( $out, '<!-- wpv-loop-end -->', $start ) !== false
        ) {
            $start = $start + strlen( '<!-- wpv-loop-start -->' );
            $out = substr( $out , $start );
            $end = strrpos( $out, '<!-- wpv-loop-end -->' );
            $out = substr( $out, 0, $end );
        }
    }
    return $out;
}

the following field is added to the post form to change the author.

      [cred_show_group if="($(car-status) eq  'sold )"  mode='fade-slide']

        <div class='col-12 text-white bg-success p-5 mb-4 rounded-10'>

            [cred_generic_field field="my_autor_select" type="select" class="form-control" urlparam=""]
            {
            "required":1,
            "validate_format":0,
            "persist":1,
            "default":[],
            "options":[ [wpv-view name="authors-select"] ]
            }
            [/cred_generic_field]

          </div>

      [/cred_show_group]

the problem is, even if this generic field is deleted from the form. the Author changes to current user who is editing the form each time.

The generic field as you can see its only an option depending on another option. this means only if one option is true then the user who is editing can chose one of the user as author.

[Christian Cox]

The code here modifies the post author regardless of whether or not the User has selected a value in the author field, or even if the field value doesn't exist in the $_POST superglobal:

$my_post = array(
      'ID'           => $post_id,
      'post_author' => $_POST['my_autor_select']
  );

If the my_autor_select value does not exist, this means the post author is undefined, which is probably the main problem here. Instead, you could pass in the current post author's ID, or you could remove the post_author key from the my_post array.

$post_author_id = get_post_field( 'post_author', $post_id );

[Nashaat]

Thanks for your quick reply Christian.

If i remove the post_author key, then the my_autor_select wont change the author of the post anymore.

I am trying to change the Author only if an option is selected in my_autor_select. If not then it should keep the same current author.

If you have an idea how to make this work it will be very helpful.

[Christian Cox]

If i remove the post_author key, then the my_autor_select wont change the author of the post anymore.
What if you try something like this:

$author_id = isset( $_POST['my_autor_select'] ) ? $_POST['my_autor_select'] : get_post_field( 'post_author', $post_id );
$my_post = array(
      'ID'           => $post_id,
      'post_author' => $author_id
  );

[Nashaat]

Thank you Christian this solved the issue.