Hello, it sounds like you are creating a post type that will act as a proxy for Users. I have answers to your questions below, and we have some related information about this process in a document you might find helpful: https://toolset.com/documentation/legacy-features/views-plugin/how-to-create-custom-searches-and-relationships-for-users/
(1) Is is okay to create posts in toolset created CPTs with user_register hook?
Yes, it is okay in general. You should be aware that this will create a post automatically any time a User is registered, even if the User is not created by a Toolset Form. If you want to limit the post generation process to be triggered only by a Form, you could use the cred_save_data hook instead of the user-register hook. The cred_save_data hook can be easily configured to fire when submitting a specific Form, or submitting specific Forms. If you use the user_register hook, the automatic process could be triggered in any number of ways, like when a User is created directly in wp-admin, or when a User is created by some 3rd-party plugin like a contact form.
(2) Does the answer to (1) change whether I use a cred form for registration?
I'm not sure I fully understand the question, but see my previous answer. If you use a Form for registration, you can use the cred_save_data hook instead to limit this automatic post creation process to be triggered only by a specific User Form. If you want to trigger the automatic process regardless of how the User is created, the user_register hook is probably preferred.
(3) If (2) is no, then what else could I be doing wrong to create a custom post on registration?
I don't think you're doing anything inherently wrong by creating the custom post on registration. The process you described seems logical. If you want to redirect to the new custom post after registration with Forms, you'll need some custom code to modify the redirection URL because there is nothing built-in to User Forms that will allow you to redirect to a post that was created programmatically as you described. In the User Form settings, you must choose to redirect to some post or page after submission, otherwise the redirection API will not be triggered.
Basic API implementation starter script:
add_filter('cred_success_redirect', 'tssupp_redirect_to_generated_profile',10,3);
function tssupp_redirect_to_generated_profile($url, $post_id, $form_data)
{
$forms = array( 123, 456 );
if ( in_array( $form_data['id'], $forms ) ) {
// add your custom code here
// first, query profile posts by author id and get the results
// get the permalink of the matching profile post
// return the permalink of that profile post
}
// otherwise, return the default redirect url
// do not edit or delete the following code
return $url;
}
Replace 123, 456 with a comma-separated list of User Form IDs where you want to apply this customized redirection, then add your custom code to query profile posts by author id and return the permalink of the profile post.
Let me know if you have follow-up questions about this, if you need more details about creating the Profile post query, etc.
