[Resolved] PHP fatal error because of Types and Smush Pro plugin

[Author]

Posts

[Peter]

Hi,

with the latest versions of Types and Smush Pro plugins, they have a conflict, that generates fatal error, when somebody wants to save a post, that have custom fields. I guess, it is with the media upload field, but not tested.

This is the error message:
[Wed Jun 17 12:17:45.564357 2020] [php7:error] [pid 6682] [client 84.0.63.37:43386] PHP Fatal error: Uncaught ArgumentCountError: Too few arguments to function Smush\\Core\\Core::big_image_size_threshold(), 1 passed in /nas/content/live/pwpleon/wp-includes/class-wp-hook.php on line 287 and exactly 4 expected in /nas/content/live/pwpleon/wp-content/plugins/wp-smush-pro/core/class-core.php:662\nStack trace:\n#0 /nas/content/live/pwpleon/wp-includes/class-wp-hook.php(287): Smush\\Core\\Core->big_image_size_threshold(2560)\n#1 /nas/content/live/pwpleon/wp-includes/plugin.php(206): WP_Hook->apply_filters(2560, Array)\n#2 /nas/content/live/pwpleon/wp-content/plugins/types/vendor/toolset/types/embedded/includes/fields/image.php(36): apply_filters(‘big_image_size_…’, 2560)\n#3 /nas/content/live/pwpleon/wp-includes/class-wp-hook.php(289): WPCF_Fields::{closure}(”:wink:\n#4 /nas/content/live/pwpleon/wp-includes/plugin.php(206): WP_Hook->apply_filters(”, Array)\n#5 /nas/content/live/pwpleon/wp-content/plugins/types/vendor/toolset/toolset-common/toolset-forms/classes/class.types.php(359): apply_filters(‘wpcf_fields_typ…’, ”, Arr in /nas/content/live/pwpleon/wp-content/plugins/wp-smush-pro/core/class-core.php on line 662, referer: hidden link

Please help me to find a solution! I also reported it to WPMU developers.

[Christian Cox]

Hi, I'm not aware of this issue but I don't have the latest version of Smush Pro available to test. Can you post it to Drive or Dropbox and provide a download link here? Or if you'd prefer, you can give me admin-level access to your site's wp-admin area so I can download it with the WP Downloader plugin.

[Christian Cox]

Correction - another User has already reported this issue for Smush, and it seems to be a problem in the free version of Smush as well as Pro. I will connect your ticket to our internal bug tracker and keep you posted as I receive updates about this compatibility issue with Smush. Please stand by and I will update you as soon as possible.

[Peter]

Thank you Christian for the quick response! I hope it will be fixed soon either on your or on WPMU's side!

[Christian Cox]

Our team has published an erratum post about this. You can follow along with that erratum here: https://toolset.com/errata/fatal-error-in-image-optimisation-plugins-when-using-types-3-3-11/

The problem was introduced by a change we made to support a change in how WP handles very large images. Hopefully a patch will be provided, and I will let you know if that happens before the plugin is updated with a long-term fix.

[Christian Cox]

- Update -

I'm happy to report that a patch has been added to the erratum post here: https://toolset.com/errata/fatal-error-in-image-optimisation-plugins-when-using-types-3-3-11/

You can follow the instructions in the erratum post to install the patch. Once installed, the Fatal Error should no longer appear. A hotfix release for the plugin will be published early next week, containing the long-term fix for the problem. I'll keep you posted here when I have a more concrete delivery schedule available.

Thanks for your patience while we worked to resolve this late-breaking compatibility issue.

[Peter]

Thank you for the update! I will wait for the official release. I already disabled the Smush Pro plugin.

[Nigel]

Hi Peter

Christian is away this week.

We just released Types 3.3.12 which includes the fix for this.

Can you go ahead and update, and if satisfied please go ahead and mark this as resolved, thank you.

[Peter]

I can confirm, that it is working now. Thank you!

[Nigel]

Great, let me mark as fixed, thanks.