I tried to replicate your site again and the results are not the same anymore.
Now I receive one "Heloooo" and one "Could not open scrap file."
I re-read this entire ticket and I am not sure this is the same issue as described in the Errata.
I rather suspect this is another issue or even a problem with the code.
1. In this code (https://toolset.com/forums/topic/hook-cred_form_validate-is-called-twice-when-custom-validation-fails/#post-624456) I suggest you only check if "invalid" and if so apply errors, as shown here:
https://toolset.com/documentation/programmer-reference/cred-api/#cred_form_validate
What you do right now is actuall return something even the validation passed.
This is not the idea of validation. There is no need for that if/else statement.
You can just chek if the value is 0 and if so, provide the errors.
If the value is more than 0, obviously that error will autmatically not apply.
According our example you return "array($fields,$errors)" if there is a failure, not when there is a success.
2. The erratum here does not involve Custom Code:
https://toolset.com/errata/cred_form_validate-api-hook-called-twice-when-javascript-is-disabled/
It's just that the public API you use is logically alos used by CRED - but in that case, it's not related to custom code validation.
it's about the native validation done in CRED/Types.
In my previous tests i logically removed any other CRED form from the layout, but my last test do not even confirm the issue anymore.
Something changed in the Updates, I assume (as there where some pending on that package).
I tried to replicate this problem (with one form only) several times now, but could not get close to a replication on a clean install.
Is it possible to receive steps that allow me to replicate this on a simple fresh install?
It seems to me this is not replicable, as long we have one form only.
As well, this issue does not need custom valdiations to be replicated, as stated in the erratum.
The BUG I am still able to replicate (if there are more than one form on the page) is replicated as follows:
- add a Custom Field in Types and make it required
- add a CRED Form with that field
- to your functions.php you add:
add_filter('cred_form_validate','my_validation',10,2);
function my_validation($error_fields, $form_data)
{
//field data are field values and errors
list($fields,$errors)=$error_fields;
//uncomment this if you want to print the field values
//print_r($fields);
//validate if specific form
if ($form_data['id']==18)
{
//check my_field value
error_log('validate');
}
//return result
return array($fields,$errors);
}
- in the front end you submit the CRED form without passing value to the required field
- the JS validation of CRED will trigger.
- now Disable JS in the browser console and repeat the submit form step.
- Watch error log and see that cred_form_validate was run twice.
What are the steps to replicate the issue report, in a similar step by step workflow?
