This thread is resolved. Here is a description of the problem and solution.
Problem: CRED Form notifications are triggered incorrectly when custom field values are changed.
Solution: Forms 2.0.2.1 includes several improvements to the custom field trigger system for Forms notifications. Please update to the latest version to receive those improvements, and you may need to re-save the Form to update existing notifications.
This support ticket is created 6 years, 7 months ago. There's a good chance that you are reading advice that it now obsolete.
This is the technical support forum for Toolset - a suite of plugins for developing WordPress sites without writing PHP.
Everyone can read this forum, but only Toolset clients can post in it. Toolset support works 6 days per week, 19 hours per day.
I did some testing locally and was able to reproduce the issue.
Notifications from an edit form were being wrongly sent whenever custom fields were changed, even if they were changed to the wrong value (and sometimes even when they had not been changed at all).
I have escalated this so that it can be addressed by the developers, and I'll let you know when I have news.
There is an imminent update of all plugins, including Toolset Forms (as CRED will now be known), but there won't be time to include a fix for this in that update.
I just performed the most recent upgrades to all of the Toolset modules - and now it seems that NONE of my notifications are triggering no matter what! (this is almost worse than all of them triggering)
You have reported the same in the other thread and so I'm taking a copy of the site referred to their for testing and will get back to you.
Regarding the original issue our lead developer has been looking into it and says that the notifications system needs a lot of work, so it may not be a quick fix to get this working 100%, but it should have basic functionality working in the current stable plugin versions, so I'll investigate why it doesn't seem to be working at all in your case and see if we can identify and fix that issue quickly.
No need to reply here unless you have something specific to add, I'll follow-up in the other thread.
I am still finding that ALL of my notifications on any given Form are triggered, no matter whether the conditional criteria is met or not. It is pretty embarssing for me as my clients are getting multiple conflicting emails from me because of this!
We have had so many problems with notifications over the past couple of years with fixes on top of fixes that it was decided to completely re-write this part of the plugin to try and resolve the problems once-and-for-all, and we are just about to publish a minor update containing the fix.
It could even come later today, but if not it will be very soon.
Sorry for the inconvenience, do let me know if you see any more problems once you've updated.
I just tested this on my Toolset Form that has four different notifications based on the content of one select field.
It ALMOST works.
It no longer sends multiple notifications no matter which selection I've made - it sends only the notification related to the selection.
However- when I choose the selection "No Email" - which does not have a notification attached to it - it sends the notification for whatever was selected just BEFORE I changed the selection to "No Email". Then, if I submit it a SECOND time with the "No Email" selection, it does NOT send the email.
So it's really close but still a little problem...
Can you clarify that last case where you have found the notifications to not work correctly?
You have a form to publish posts.
What fields does the form contain that are relevant to the notifications?
What are the settings for the problem notification (i.e. what triggers it)?
What are the steps to generate the false notification?
I need to try and reproduce the problem on a local test site (I recall problems taking a copy of your site for testing because of some required plugin your sites are built with).
For example, the same CPT and form from my original post (Reply #902633) is still not working exactly correctly.
I just saved a record from that CPT (not even using the Toolset Form, just saving it in the WordPress version of the CPT) - where the value of the conditional field "project-personnel-done" is set to "FILE ACCESS INSTRUCTIONS SET".
In the Toolset form "Project Personnel Edit Form", It is only supposed to send a notification if that is the field value but only if the value of the field has CHANGED (which it had not - but the notification went anyway).
If I change the value to "EMAILED" (which does NOT have a notification associated with it) and save the record again, it does NOT send a notification - which is good!
But I would want it also to NOT send a notification if the field value is still "FILE ACCESS INSTRUCTIONS SET" but I have ticked to not trigger a notification unless that field value has changed.
Okay thanks for the additional information. The recent update did include some but not all of the rewritten notification system, and we hope to include a more thorough version in the next release of Forms. I'll keep you posted here so we can verify everything is working as expected once that update is live.
I'm not sure what the status of this is now? There was an update recently that seemed to fix the problems - but then there was another update a day or two later and all the problems came back!
Yes, the notification trigger updates are still in progress. I will change the status of this ticket to "Escalated" since it's still under development.
Hi Elise, my 2nd tier team corrected some information I received yesterday, and it turns out that this should have been resolved in the latest Forms update, version 2.0.2.1. I checked the screenshots you provided earlier, and I can see in Screenshot 4 that the notification trigger is "When submitting the form". Please note that this setting overrides the custom field value trigger, and will result in this notification being sent any time the form is submitted. If you want to test a custom field value, you must choose the setting "When custom fields are modified". Please verify these trigger settings are correct, then test again with Forms 2.0.2.1. If you still experience problems, I need to know:
- What type of custom field is "project-personnel-done"?
- You mentioned that this is a conditional field. Can you explain this a bit more? Do you mean there is conditional display applied to this custom field in the Field Group editor, or just that the notification trigger is conditional based on this field?
I can see that you are right in the instance of that particular notification that the wrong box was ticked.
As of yesterday, I had submitted another form with multiple notifications where the box WAS ticked properly, and they were triggering inaccurately - but when I test them this morning they now all seem to be working fine (including the one referenced above once I ticked the correct box).
I also just went to another site I operate and tried a similar notification there, and it triggered incorrectly until AFTER I re-saved the form (without making any other changes to it) - THEN it began to work properly.
Perhaps I just need to make sure I go into all of my post forms that have notifications and SAVE the forms in order to have the update take effect - but at any rate, it seems to be all working now - thanks very much for fixing this great function!
(by the way - project-personnel-done is just a regular "select" field - I only meant that the notification triggered was "conditional" on the value of that select field)
