Hi Simon
This is Juan here, lead Views developer. After checking that there is no issue between what your site produces and what I would xpect it to produce, and as you obviously disagree, I was wondering if we migth be missing something here. And I have an idea that might explain that.
Let me recap, and excuse if I get too long.
You have a render_view_template() call. It is loading a Content Template and applying it to a post wich ID you are getting from the Global Content Blocks shortcode, in form of a %%postid%% variable.
You are doing this not because you want to load the Content Template, which is empty (so it rightful outputs nothing), but because you want to set some post data that the View shortcode below it should be using. This is what "Load Photographer" means: load this photographer post, without displaying anything on a Content Template so its data is then used by the View below. Right?
Now, that wpv-view shortcode is loading a View that has a filter that expects some data to be set on a parent View, right? It has a filter to return posts that are children of the post set on the parent View. And you assume, because it worked before, that the parent View is the data that the render_view_template is setting, meaning the View will load posts that are children of the photographer with ID the %%postid%% value that you got from the Global Content Blocks shortcode.
So, as a summary: you are loading an empty Content Template to set a photographer that should be used as ID set by the parent View on a query filter of another View.
------------------------
That is the explanation of the situation, if I am not wrong.
Now, the issue is that this filter data, "Select post that are chldren of the post set by a parent View" only works on nested Views. The fact that you are setting the photographer using a Content Template does not set a parent View at all. In the past, that hapened, and we considered it a bug, and changed how it works. From now on, filters that demand data from the parent View will only work with real nested Views.
But this should not be a problem to you. I am offering you a solution.
* First, please do not load an empty Content Template. It is not needed anywhere. So every call that you are making to
echo render_view_template('8581', $thispost);
is useless because the Content Template with ID 8581 is empty. So in fact the Content Block "COD, Phr - Load Photographer by ID" is, well, useless and I recommend you to not use it anymore anywhere. I am attaching a screenshot of the change I have done on the Content Block "COD, Phr - Most Favorite Gear" and you will notice that I have passed the %%postid%% directly to the wpv-view shortcode in the attribute "wpvprchildof"
* Second, you can set the parent photographer directly into the View to render its "Photographers-Gears" children. Notice that we used the attribute"wpvprchildof" before? I am attaching a screenshot of the filter in the "phr-Gear-MostFavorite" View so you can notice how I used it.
I think the results are what you would expect. Here:
hidden link
under the "Killer Kit Awards" title, you can see what I assume is what you expect.
Please let me know if you need any further explanation, and if this solves your issue. Also, please acept my apologies for this issue, as it has taken too long to completely understand it and offer a solution.
Hope this all helped a little 🙂
Regards