Provided patch no longer works with latest Toolset plugins

Ce fil est résolu. Voici une description du problème et la solution proposée.

Problem:
The customer reported that the patch we provided earlier for fixing an image resizing issue, no longer works.

Solution:
Guided that further testing confirms that the previously provided patch doesn't work with PHP 8 and shared an updated patch.

Relevant Documentation:
https://toolset.com/errata/custom-sized-images-not-working-when-output-via-types-shortcode/

This support ticket is created Il y a 4 years, 5 months. There's a good chance that you are reading advice that it now obsolete.

This is the technical support forum for Toolset - a suite of plugins for developing WordPress sites without writing PHP.

Everyone can read this forum, but only Toolset clients can post in it. Toolset support works 6 days per week, 19 hours per day.

Sun	Mon	Tue	Wed	Thu	Fri	Sat
-	9:00 – 13:00	9:00 – 13:00	9:00 – 13:00	9:00 – 13:00	9:00 – 13:00	-
-	14:00 – 18:00	14:00 – 18:00	14:00 – 18:00	14:00 – 18:00	14:00 – 18:00	-

Fuseau horaire du supporter : Asia/Karachi (GMT+05:00)

Ce sujet contient 8 réponses, a 3 voix.

Dernière mise à jour par - Il y a 4 years, 5 months.

Assisté par: Waqar.

Author

Publications

mai 25, 2022 at 9:16 #2370659

simonM-5

Hi Support

We recently raised ticket: https://toolset.com/forums/topic/photo-not-resizing-correctly-when-filename-contains-cyrillic-characters/

The provided patch

wp-content/plugins/types/vendor/toolset/types/embedded/views/image.php

no longer works with the latest version of the Toolset plugins.

1) Could you please provide the same patch for the latest versions of the Toolset plugins?
2) Is the fix planned to be included permanently in a future plugin update?

On a side note, we upgraded also to WP 5.9.3 to WP 6.0 and PHP 8.0 from PHP 7.4 yesterday, but the problem existed already before that, so I'm fairly certain it is the Toolset plugin at fault. Can you please ensure the new patch (and later the permanent fix) also works in this supported configuration?

Thanks and best regards
Simon

mai 25, 2022 at 12:30 pm #2370755

Nigel

Hi Simon

To clarify, can you confirm that you updated Types and then added back the patch?

The fix for that issue came too late for the releases, and will be included in the next version of Types. In the meantime the patch needs to be added again.

If that's what you did and it doesn't work, then we'll re-evaluate the changes.

mai 25, 2022 at 5:34 pm #2371029

simonM-5

Hi Nigel

Yes, that is correct. Updated all Toolset plugins to latest version and then re-applied the patch to see if it fixed it, but alas no.

Are you saying that the patch should also work for the latest plugin version of Types, PHP8 and WP6? I cannot confirm this

Kind regards
Simon

mai 26, 2022 at 9:22 #2371615

Waqar

Hi Simon,

Thank you for confirming that.

We're currently performing some further tests and will share the results, as soon as this testing completes.

Thank you for your patience.

regards,
Waqar

mai 26, 2022 at 12:48 pm #2371733

Waqar

Thank you for waiting.

Our testing confirms that the patch works with the latest Types (3.4.16) and WordPress (6.0), but not with PHP 8.

For now, you can downgrade to PHP 7 and I'll keep you updated on the further progress through this ticket.

mai 27, 2022 at 1:08 pm #2372703

Waqar

I'd like to update you that an updated patch is available, that can be downloaded from this errata page:
https://toolset.com/errata/custom-sized-images-not-working-when-output-via-types-shortcode/

mai 27, 2022 at 1:39 pm #2372719

simonM-5

Hi Waqar

Thanks for that. We will test out a few scenarios and let you know the results!

Kind regards
Simon

mai 30, 2022 at 4:19 #2373905

Waqar

Sure, please take your time and let us know how it goes.

mai 30, 2022 at 7:55 #2373943

simonM-5

Hi the patch seems to have done the trick, I can confirm it is working with the configuration WordPress 6.0, PHP 8.0 and the latest Toolset plugins.

My issue is resolved now. Thank you!