Skip Navigation

[Resolved] Mixed content in plugin

This thread is resolved. Here is a description of the problem and solution.

Problem:

That the icon for links to external sites comes from a non https source

body .modman-inline-module-manager .modman_learn_about_modules a[href^="//"]::after, body .modman-inline-module-manager .modman_learn_about_modules a[href^="http://"]::after, body .modman-inline-module-manager .modman_learn_about_modules a[href^="https://"]::after {
content: url(http://upload.wikimedia.org/wikipedia/commons/6/64/Icon_External_Link.png);
margin: 0 0 0 5px;
}

Solution:

Thanks for the details, I can see the problem in plugin "toolset-module-manager", the codes are in two files:

\toolset-module-manager\embedded\views\templates\inline.tpl.php
Line 31:

And

\toolset-module-manager\views\templates\inline.tpl.php

Line 31:

currently you can change the above two line codes to:

content: url(//upload.wikimedia.org/wikipedia/commons/6/64/Icon_External_Link.png);

Relevant Documentation:

This support ticket is created 6 years, 9 months ago. There's a good chance that you are reading advice that it now obsolete.

This is the technical support forum for Toolset - a suite of plugins for developing WordPress sites without writing PHP.

Everyone can read this forum, but only Toolset clients can post in it. Toolset support works 6 days per week, 19 hours per day.

Sun Mon Tue Wed Thu Fri Sat
- 9:00 – 13:00 9:00 – 13:00 9:00 – 13:00 9:00 – 13:00 9:00 – 13:00 -
- 14:00 – 18:00 14:00 – 18:00 14:00 – 18:00 14:00 – 18:00 14:00 – 18:00 -

Supporter timezone: Asia/Hong_Kong (GMT+08:00)

This topic contains 5 replies, has 2 voices.

Last updated by peterS-14 6 years, 9 months ago.

Assisted by: Luo Yang.

Author
Posts
#621058

I just noticed the following on several parts of the latest toolset beta plugins, that the icon for links to external sites comes from a non https source

body .modman-inline-module-manager .modman_learn_about_modules a[href^="//"]::after, body .modman-inline-module-manager .modman_learn_about_modules a[href^="hidden link"]::after, body .modman-inline-module-manager .modman_learn_about_modules a[href^="hidden link"]::after {
content: url(hidden link);
margin: 0 0 0 5px;
}

I know it's still a beta version, but I hope this feedback might help to get it fixed until the final release

Best Regards

#621212

Hi,

Are we talking about the URL "hidden link" you mentioned above?

I have searched it in the source code of latest version Toolset beta plugins:
Toolset Types 2.3-b3
Toolset Views 2.6-b3
Toolset CRED 2.0-b1

But can not find any result, could you point the file path and file name where I can see the problem codes?

#621263
Toolset Mixed Content 2.JPG
Toolset Mixed Content.JPG

Hi Luo

thanks for your reply

I noticed this everywhere where the Module Manager parts with the "Learn more about Modules" link shows up.

Best regards

#621275

Hi Luo

I just checked on a Site with the Stable Toolset Versions and there happens the same, so imho it looks like this is coming from the Toolset Module Manager 1.6.9 and not from the Beta Versions.

Best regards

#621277

Thanks for the details, I can see the problem in plugin "toolset-module-manager", the codes are in two files:
\toolset-module-manager\embedded\views\templates\inline.tpl.php
Line 31:

content: url(<em><u>hidden link</u></em>);

\toolset-module-manager\views\templates\inline.tpl.php
Line 31:

content: url(<em><u>hidden link</u></em>);

And I tested the URL in my browser directly, it redirect me to new URL with SSL automatically:
hidden link

currently you can change the above two line codes to:

content: url(//upload.wikimedia.org/wikipedia/commons/6/64/Icon_External_Link.png);

Please test it and feedback if it is fixed, and I will escalate this thread to our developers, thanks

#621293

Hi Luo

thanks a lot for looking into this.
I edited the files according your instructions and it works great now

Best regards, Peter