[Resolved] Bug: bad input on repeat password field trigger JS error

[Author]

Posts

[Francesco]

Note: This is not a support request, it's a bug report along with the fix. Please escalate this to the DEV team.

I made a CRED user form for new user registration, with a "Repeat password" field.
When a user submits a wrong password pair (different passwords) a javascript (jQuery) error is triggered because of the following snippet injected by CRED:

<script language="javascript">
            jQuery(document).ready(function(){jQuery('[data-wpt-name="user_pass"]:first').parent().insertAfter('[data-wpt-name="user_pass"]:first');jQuery('[data-wpt-name="user_pass2"]:first').parent().insertAfter('[data-wpt-name="user_pass2"]:first');});
            </script>

I tracked down the problem to file cred-frontend-editr/embedded/classes/CredForm.php, inside function getFieldsErrorMessagesJs (around line 3555 in my version of the file).
The offending code is the following:

$js.='jQuery(\'[data-wpt-name="' . $id_field . '"]:first\').parent().insertAfter(\'[data-wpt-name="' . $id_field . '"]:first\');';

which clearly is wrong, as it tries to insert the parent of an element after the element itself, without detaching it from the DOM.

Luckily two lines above there was a commented alternate version, which seems to work as expected:

$js.='if (jQuery(\'[data-wpt-name="' . $id_field . '"]:first\').length) jQuery("#lbl_' . $id_field . '").detach().insertAfter(\'[data-wpt-name="' . $id_field . '"]:first\');

I switched the two lines (uncommented the first and commented the second) and it looks fine.

I hope you will update this in the next CRED version.

Thank you.

[Luo Yang]

Dear Francesco,

Thanks for the feedback, I have been able to duplicate same problem, and put it into our to-do list, our developers will take care of it.

[Francesco]

Thanks. Is there an ETA for the release of this fix? It looks that in the latest release (1.5.2) the problem is still present.

[Luo Yang]

Here is the feedback from our developers:
1) it is fixed in future version of CRED 1.6, which is still in development status
2) currently, you can try the workaround in Erratas:
https://toolset.com/errata/password-field-not-appearing-field-validation-triggered/